fix: infinite loop

Author: kasin-it

src/sandbox/run-agent.ts

@@ -1,9 +1,19 @@
 import type { Sandbox as SandboxType } from "@vercel/sandbox";
-import { getWritable } from "workflow";
+import { getWritable, FatalError } from "workflow";
 import { buildAgentCommand, parseAgentOutput, formatStreamEvent } from "./agent-runner.js";
 import type { AgentOutput } from "./agent-runner.js";
 import { SandboxManager } from "./manager.js";
 
+const NON_RETRYABLE_PATTERNS = [
+  /credit balance is too low/i,
+  /insufficient.?quota/i,
+  /billing/i,
+  /invalid.?api.?key/i,
+  /authentication/i,
+  /unauthorized/i,
+  /permission.?denied/i,
+];
+
 type SandboxInstance = Awaited<ReturnType<typeof SandboxType.create>>;
 
 interface RunAgentOptions {
@@ -69,10 +79,22 @@ export async function runAgent(
 
     const raw = stdout.trim() || stderr.trim();
     const output = parseAgentOutput(raw);
+
+    const combinedText = `${output.error ?? ""} ${stderr}`;
+    if (NON_RETRYABLE_PATTERNS.some((p) => p.test(combinedText))) {
+      throw new FatalError(`Non-retryable agent error: ${output.error ?? stderr.slice(0, 500)}`);
+    }
+
     return { output, files };
   } catch (err) {
     await manager.runEndHook(sandbox).catch(() => {});
     const files = await manager.extractChanges(sandbox).catch(() => []);
+
+    const msg = (err as Error).message ?? "";
+    if (NON_RETRYABLE_PATTERNS.some((p) => p.test(msg))) {
+      throw new FatalError(`Non-retryable agent error: ${msg}`);
+    }
+
     throw Object.assign(err as Error, { files });
   } finally {
     await manager.teardown(sandbox);

src/workflows/implementation.ts

@@ -66,6 +66,7 @@ async function runAgentInSandbox(
   const sandbox = await manager.provision(branchName, requirementsMd);
   return runAgent({ sandbox, manager, model: env.CLAUDE_MODEL, debug: env.DEBUG_AGENT });
 }
+runAgentInSandbox.maxRetries = 0;
 
 async function pushChanges(
   branchName: string,
@@ -165,7 +166,7 @@ export async function implementationWorkflow(ticketId: string) {
     return;
   }
 
+  await moveTicket(ticketId, env.COLUMN_BACKLOG);
   await notifySlack(`Task ${ticket.identifier} failed: ${output.error ?? "unknown error"}`);
   await unregisterRun(ticket.identifier);
-  throw new Error(`Agent failed for ${ticketId}: ${output.error}`);
 }

src/workflows/review-fix.ts

@@ -79,6 +79,7 @@ async function runFixingAgentInSandbox(
   const sandbox = await manager.provision(branchName, requirementsMd);
   return runAgent({ sandbox, manager, model: env.CLAUDE_MODEL, debug: env.DEBUG_AGENT });
 }
+runFixingAgentInSandbox.maxRetries = 0;
 
 async function pushChanges(
   branchName: string,
@@ -146,7 +147,7 @@ export async function reviewFixWorkflow(
     return;
   }
 
+  await moveTicket(ticketId, env.COLUMN_BACKLOG);
   await notifySlack(`Task ${ticket.identifier} review-fix failed: ${output.error ?? "unknown error"}`);
   await unregisterRun(ticket.identifier);
-  throw new Error(`Agent failed for ${ticketId}: ${output.error}`);
 }