[StarCraft II]: SC2 x64 fails to start

[dllu]

What Game
StarCraft II 5.0.15.96883 SC2_x64.exe

Installed from battle.net

Describe the bug
Starcraft II fails to launch in Proton 10 or 11 in x64 mode on an NVIDIA DGX Spark

In "32-bit client" mode, it launches in Proton 10, but it quickly crashes due to OOM unless playing simple game modes at a low resolution on lowest graphics settings.

To Reproduce

1. Add battle.net setup as a "non-steam game" in Steam using any working version of Steam (e.g. via the Steam snap app, or fex_autoinstall)
2. Set compatibility to Proton 10
3. Install Starcraft 2
4. Try launching
5. Next, try cloning the bleeding edge proton, compiling it for arm64, and then using the following script to launch the SC2 that you've just installed but without Steam: https://gist.github.com/dllu/a0400131eac42468acdc71cd656c13c5

Finally, checkout my compilation branch of #5508, #5509, #5510, and #5511 here: https://github.com/dllu/FEX/tree/dllu/fex-sc2-x64-arm64 and compile Proton etc and relaunch SC2 with the above script. It should work.

Expected behavior
A clear and concise description of what you expected to happen. The game should launch.

Screenshots and Video

Launching the game without my branch fails with an obtuse error

However, with my fixes, it works smoothly.

System information:

• OS: Ubuntu 24.04.4 LTS
• CPU/SoC: NVIDIA GB10
• Video driver version: NVIDIA 580.159.03
• RootFS used: [eg: Ubuntu 21.10 Official Rootfs]
• FEX version: (FEXGetConfig --version) [eg: FEX-2112-155-gc691d709]
• Thunks Enabled: Yes

Additional context

• Is this an x86 or x86-64 game: [x86/x86-64/Both]
• Does this reproduce on AArch64 with Radeon/Intel/Nvidia: [Yes/No/Untested]
• Is this a Vulkan game: [Yes/No/Unknown] No
  • If Yes, What is your Vulkan driver:

Add any other context about the problem here.

Fixed in #5508, #5509, #5510, #5511

Additional details: canonical/steam-snap#501

[FrontMage]

Wonder if the fix works on World of Warcraft as well

[dllu]

Wonder if the fix works on World of Warcraft as well

In #5399 you mentioned:

the next area to investigate is how Wine/FEX exposes live ntdll thunk/trampoline bytes compared with native Windows

I think the problem is probably similar. In the case of SC2, it reads ARM64X ntdll.dll bytes into a private buffer and later executes copied thunk bytes from there. update_arm64x_mapping() never sees that buffer. I have local AI-generated patches to get it working on my machine (https://gitlab.winehq.org/dllu/wine/-/commits/dllu/arm64x-ntreadfile-fix), but I can't create a merge request for the changes obviously since Wine (and FEX too) do not allow AI-generated patches, and I'm too dumb to fix it by hand.

@bylaws is right that my garbage slop PRs #5509 and #5511 that patch around it in a hacky way aren't the right fix. But I don't see an obvious clean fix in the Wine side either.

[FrontMage]

@dllu Thanks for the guide and fixes. I can confirm that this fix can be adjusted to push WoW further in the TLS handler; the question became very complicated under ARM64EC since Proton11's ntdll is a mixture of x86 instructions and ARM instructions.
But I cannot reproduce SC2 successfully running on the ARM64EC environment; can you share your setup?