Skip to content

shallowEqual compare does not correctly update its value #111

Description

@NickKirschke

@aem

When returning multiple values from a dependency within an object, the shallowEqual incorrectly evaluates whether or not there was a change in value depending on the order and type of these values. If both values are updated, the dependency will recalculate.

// Updating only the bar ImmutableMap below will not trigger a value update for this dependency
{
  foo: [123],
  bar: ImmutableMap({
    baz: "baz"
  }),
}

// Updating only the bar ImmutableMap below will trigger a value update for this dependency
{
  bar: ImmutableMap({
    baz: "baz"
  }),
  foo: [123],
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions