refactor: simplify check_kp_multi.sh to remove unused lat/lon parameters

- Removed TARGET_LAT and TARGET_LON (not needed for YR.no location-based API)
- Simplified script parameters: now only min_kp and optional yr_location_id
- Updated log structure to use location_id instead of lat/lon coordinates
- Updated workflow to call script with simplified parameters
- Cleaner API focused on YR.no's location-based system

Author: turbolego

.github/workflows/post.yml

@@ -28,7 +28,7 @@ jobs:
         id: kp_check
         if: steps.darkness.outcome == 'success'
         run: |
-          OUTPUT=$(bash src/check_kp_multi.sh 59.959103 10.4592208 3)
+          OUTPUT=$(bash src/check_kp_multi.sh 3)
           echo "$OUTPUT"
           # Extract VALIDATED_KP from output and save to GITHUB_OUTPUT
           VALIDATED_KP=$(echo "$OUTPUT" | grep "VALIDATED_KP=" | cut -d'=' -f2)

README.md

@@ -143,12 +143,7 @@ Trigger a manual run:
 
 - Tryvann: yr.no public webcams (directional views)
 - Sylling: yr.no public webcams
-## Resources
-
-- [YR.no Aurora Forecast API](https://www.yr.no/en/content/1-83651/the-api-now-supports-an-auroraforecast-endpoint) - Real-time aurora data used by the bot
-- [Space Weather Prediction Center](https://www.swpc.noaa.gov/) - Official NOAA space weather site
-- [Aurora forecast for Norway](https://www.aurora-service.eu/aurora-forecast/) - Additional forecast source
-- [Bluesky API Documentation](https://docs.bsky.app/) - Bluesky API reference
+## Privacy
 
 - Only processes public webcam feeds
 - No personal data collected or stored
@@ -166,9 +161,10 @@ Feel free to:
 
 ## Resources
 
-- [Space Weather Prediction Center](https://www.swpc.noaa.gov/)
-- [Aurora forecast for Norway](https://www.aurora-service.eu/aurora-forecast/)
-- [Bluesky API Documentation](https://docs.bsky.app/)
+- [YR.no Aurora Forecast API](https://www.yr.no/en/content/1-83651/the-api-now-supports-an-auroraforecast-endpoint) - Real-time aurora data used by the bot
+- [Space Weather Prediction Center](https://www.swpc.noaa.gov/) - Space weather information
+- [Aurora forecast for Norway](https://www.aurora-service.eu/aurora-forecast/) - Additional forecast source
+- [Bluesky API Documentation](https://docs.bsky.app/) - Bluesky API reference
 
 ## License
 

src/check_kp_multi.sh

@@ -3,17 +3,14 @@
 # KP/aurora check using YR.no API.
 # Returns exit 0 if YR.no indicates aurora activity (kpIndex > threshold), else 1.
 #
-# Usage: check_kp_multi.sh <lat> <lon> <min_kp> [yr_location_id]
+# Usage: check_kp_multi.sh <min_kp> [yr_location_id]
 
 set -euo pipefail
 
 # Configuration
-YR_LOCATION_ID=${4:-"1-72662"}  # Default: Lommedalen
+MIN_KP=${1:-3}
+YR_LOCATION_ID=${2:-"1-72662"}  # Default: Lommedalen
 YR_URL="https://www.yr.no/api/v0/locations/${YR_LOCATION_ID}/auroraforecast?language=nb"
-
-TARGET_LAT=${1:-59.959103}
-TARGET_LON=${2:-10.4592208}
-MIN_KP=${3:-3}
 KP_DATA_DIR="kp_data"
 
 # Result trackers
@@ -76,15 +73,13 @@ FILE="${DIR}/${YEAR}_${MONTH}.jsonl"
 
 LOG_LINE=$(jq -n \
   --arg ts "$TS" \
-  --argjson lat "$TARGET_LAT" \
-  --argjson lon "$TARGET_LON" \
+  --arg location_id "$YR_LOCATION_ID" \
   --argjson yr_kp "${YR_KP_INDEX:-0}" \
   --argjson yr_aurora "$YR_AURORA_MAX" \
   --arg yr_triggered "$YR_TRIGGERED" \
   '{
     timestamp: $ts,
-    target_lat: $lat,
-    target_lon: $lon,
+    location_id: $location_id,
     yr: {kp_index: $yr_kp, aurora_value: $yr_aurora, triggered: ($yr_triggered == "true")}
   }'
 )

src/main.py

@@ -69,65 +69,6 @@ def get_ai_token() -> Optional[str]:
 logging.basicConfig(level=logging.INFO, format='%(asctime)s - %(levelname)s - %(message)s')
 azure_rate_limited = False
 
-# Aurora / Kp data source (Ovation model latest snapshot)
-OVATION_URL = "https://services.swpc.noaa.gov/json/ovation_aurora_latest.json"
-
-def fetch_current_kp(lat: float = 59.0, lon: float = 10.0) -> Optional[float]:
-    """Fetch a local Kp-like value for given coordinates (default Lommedalen area ~59N,10E) using Ovation model.
-
-    The endpoint returns a JSON object containing a list of coordinate triples: [latitude, longitude, value].
-    Example target triple: [59, 10, 0] -> we interpret the third number as localized activity (proxy for Kp / auroral intensity).
-
-    Return:
-        float value (third element) if exact or nearest coordinate found, else None.
-    Notes:
-        - This is a localized intensity proxy, not necessarily the global planetary Kp.
-        - We perform nearest-neighbor match (within 1 degree) if exact integer lat/lon not present.
-    """
-    try:
-        resp = requests.get(OVATION_URL, timeout=12)
-        resp.raise_for_status()
-        data = resp.json()
-    except Exception as e:
-        logging.warning(f"Ovation request failed: {e}")
-        return None
-
-    coords = data.get("coordinates") or data.get("data") or []
-    if not isinstance(coords, list) or not coords:
-        logging.debug("Ovation payload missing 'coordinates' list")
-        return None
-
-    target_lat = int(round(lat))
-    target_lon = int(round(lon))
-
-    exact_match_val: Optional[float] = None
-    nearest_val: Optional[float] = None
-    nearest_dist: float = 9999.0
-
-    for triple in coords:
-        if not (isinstance(triple, list) and len(triple) >= 3):
-            continue
-        c_lat, c_lon, c_val = triple[0], triple[1], triple[2]
-        # Basic validation of numeric types
-        if not (isinstance(c_lat, (int, float)) and isinstance(c_lon, (int, float)) and isinstance(c_val, (int, float))):
-            continue
-        if int(c_lat) == target_lat and int(c_lon) == target_lon:
-            exact_match_val = float(c_val)
-            break
-        # Track nearest within reasonable range (<=1 degree separation)
-        dist = abs(c_lat - lat) + abs(c_lon - lon)
-        if dist < nearest_dist and dist <= 1.0:
-            nearest_dist = dist
-            nearest_val = float(c_val)
-
-    kp_local = exact_match_val if exact_match_val is not None else nearest_val
-    if kp_local is None:
-        logging.debug("No suitable Ovation coordinate match for specified location")
-        return None
-
-    logging.info(f"Local Ovation intensity (proxy Kp) at ~({target_lat},{target_lon}) = {kp_local:.2f}")
-    return kp_local
-
 
 def get_validated_kp() -> Optional[float]:
     """Read the most recent KP data from bash script logs (YR.no validation).