Skip to content

Commit d3ef0e4

Browse files
committed
Fixed: update review changes, remove callback from render form , add icon on view logs button
1 parent 3968b69 commit d3ef0e4

2 files changed

Lines changed: 2 additions & 12 deletions

File tree

modules/qlocrontaskmanager/controllers/admin/AdminCronTaskManagerController.php

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ public function initToolbar()
154154
$this->page_header_toolbar_btn['view_all_logs'] = array(
155155
'href' => $this->context->link->getAdminLink('AdminCronTaskLogs'),
156156
'desc' => $this->l('View All Logs'),
157-
'icon' => 'process-icon-list',
157+
'icon' => 'icon-history',
158158
);
159159
}
160160

@@ -215,16 +215,6 @@ public function renderForm()
215215
'hint' => $this->l('e.g. send_daily_report'),
216216
'desc' => $this->l('A unique snake_case identifier for this task within the module. Used to detect duplicate registrations.'),
217217
),
218-
array(
219-
'type' => 'text',
220-
'label' => $this->l('Callback Method'),
221-
'name' => 'callback',
222-
'required' => true,
223-
'disabled' => true,
224-
'col' => 5,
225-
'hint' => $this->l('e.g. runDailyReport'),
226-
'desc' => $this->l('The public method name on the module class that will be called when this task fires. Must exist on the module at runtime.'),
227-
),
228218
array(
229219
'type' => 'text',
230220
'label' => $this->l('Description'),

modules/qlocrontaskmanager/views/templates/admin/cron_task_manager/qctm_reset_module_crons_link.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@
2121
*}
2222

2323
<a href="{$resetLink|escape:'html'}" title="{l s='Reset Module Crons' mod='qlocrontaskmanager'}"
24-
onclick="return confirm('{l s='Reset this task to the module default values?' mod='qlocrontaskmanager' js=1}');">
24+
onclick="return confirm('{l s='Are you sure? This will revert the task settings to the module\'s original values.' mod='qlocrontaskmanager' js=1}');">
2525
<i class="icon-refresh"></i> {l s='Reset' mod='qlocrontaskmanager'}
2626
</a>

0 commit comments

Comments
 (0)