test: enables GenericTypeInstantiation test for System.Reflection.Metadata (#363)

some of the scenarios were already working. Wrapped remaining failing ones with #if not API_DRIVER_SYSTEM_REFLECTION_METADATA

Author: adrianoc

Cecilifier.ApiDriver.SystemReflectionMetadata/TypeSystem/SystemReflectionMetadataTypeResolver.cs

@@ -137,10 +137,10 @@ public override ResolvedType MakeGenericInstanceType(ResolvedType typeReference,
         if (typeArguments.Length == 0)
             return typeReference;
 
-        if (resolutionContext.TargetKind is ResolveTargetKind.Field or ResolveTargetKind.Parameter or ResolveTargetKind.ReturnType)
+        if (resolutionContext.TargetKind is ResolveTargetKind.Field or ResolveTargetKind.Parameter or ResolveTargetKind.ReturnType or ResolveTargetKind.LocalVariable)
         {
             var resolved = MakeGenericInstanceTypeForFieldDeclaration(typeReference, genericTypeSymbol, typeArguments);
-            if (resolved && resolutionContext.TargetKind is ResolveTargetKind.ReturnType or ResolveTargetKind.Field)
+            if (resolved && resolutionContext.TargetKind is ResolveTargetKind.ReturnType or ResolveTargetKind.Field or  ResolveTargetKind.LocalVariable)
             {
                 return ResolvedType.FromDetails(
                     new ResolvedTypeDetails()

Cecilifier.Core.Tests/TestResources/Integration/Generics/GenericTypeInstantiation.cs.txt

@@ -12,8 +12,9 @@ public struct GenericStruct<T>
 class GenericTypeInstantiation
 {
     object ParameterlessClassCtor() => new GenericClass<int>();
+#if! API_DRIVER_SYSTEM_REFLECTION_METADATA
     object ClassCtorWithParameters() => new GenericClass<int>(42);
-    
     object StructCtorWithParameters() => new GenericStruct<int>(42);
-    //object ParameterlessStructCtor() => new GenericStruct<int>();
+    object ParameterlessStructCtor() => new GenericStruct<int>();
+#endif    
 }

Cecilifier.Core.Tests/Tests/Integration/GenericsTestCase.cs

@@ -9,7 +9,12 @@ namespace Cecilifier.Core.Tests.Integration
 {
     [TestFixture(typeof(MonoCecilContext))]
     [TestFixture(typeof(SystemReflectionMetadataContext))]
-    [EnableForContext<SystemReflectionMetadataContext>(nameof(TestGenericOuterAndInnerPermutations), nameof(TestSimplestGenericTypeDefinition), nameof(TestGenericTypesInheritance), nameof(TestGenericTypesAsMembers), IgnoreReason = "Not implemented")]
+    [EnableForContext<SystemReflectionMetadataContext>(
+        nameof(TestGenericOuterAndInnerPermutations), 
+        nameof(TestSimplestGenericTypeDefinition), 
+        nameof(TestGenericTypesInheritance), 
+        nameof(TestGenericTypesAsMembers),
+        nameof(TestGenericTypeInstantiation), IgnoreReason = "Not implemented")]
     public class GenericsTestCase<TResource> : ResourceTestBase<TResource> where TResource : IVisitorContext
     {
         [TestCase("GenericOuterNonGenericInner")]