Follow-up from PR #1215 review (suggested by @jasonqinzhou): #1215 (comment)
Observation: src/aiconfigurator/sdk/task_v2.py has grown large, with substantial agg/disagg mode and prefill/decode role if-else branching in the sweep-config generation path. It would benefit from a refactor (e.g. role/mode strategy objects or shared helpers) to make the config-generation flow cleaner and easier to extend.
Why deferred: A sizable refactor of its own; kept out of the already-large v1→v2 integration PR #1215 to keep that diff reviewable. Tracking here.
Scope: src/aiconfigurator/sdk/task_v2.py (no behavior change intended; guarded by the existing task_v2 unit tests and the v1↔v2 parity test).
Follow-up from PR #1215 review (suggested by @jasonqinzhou): #1215 (comment)
Observation:
src/aiconfigurator/sdk/task_v2.pyhas grown large, with substantial agg/disagg mode and prefill/decode role if-else branching in the sweep-config generation path. It would benefit from a refactor (e.g. role/mode strategy objects or shared helpers) to make the config-generation flow cleaner and easier to extend.Why deferred: A sizable refactor of its own; kept out of the already-large v1→v2 integration PR #1215 to keep that diff reviewable. Tracking here.
Scope:
src/aiconfigurator/sdk/task_v2.py(no behavior change intended; guarded by the existing task_v2 unit tests and the v1↔v2 parity test).