[FR]: assets support for rspack "publicDir"

[jbedard]

Currently absolute paths map to the repo root.

Maybe absolute paths for assets (only jsx assets?) should map to:

1. the parent directory containing a package.json, falling back to the worksapce root
2. the parent "assets directory" if configured via
   a. a js_assets_dir directive
   b. rspack publicDir (probably won't support this and you must duplicate this config in a directive)

See rspack static assets for more info about asset resolution

[Aghassi]

While I currently don't need this feature, I'm commenting here as having a configurable path would be nice to have if necessary for those use cases.

[walkerburgin]

It would be really helpful to have something similar to # gazelle:js_files to add additional files to assets that are never explicitly imported. For example, Storybook has staticDirs which is similar to webpack/rspack's publicDir.

I'm trying to upgrade and getting could not merge expression everywhere we were previously using a glob() without an obvious alternative.

[jbedard]

@walkerburgin this would be for ts_project(assets)?

Something such as:

# gazelle:js_asset_files [target] glob

to add files matching that glob to the specified ts_project? So you could have:

# gazelle:js_files stoires **/*.story.ts
# gazelle:js_asset_files stories **/publicDir/**

?

[walkerburgin]

Yeah, exactly.

For now we're working around this by adding an additional_assets attribute to our ts_project() wrapper, and then merging assets and additional_assets inside of the macro 🙈 .

[jbedard]

@Aghassi would the suggested API work for any use case you have atm?

# gazelle:js_asset_files [target] glob
# gazelle:js_asset_files [target] glob2

If you leave the target out then it applies to the default ts_project. Repeating multiple times appends to the list. Repeating in a sub-directory extends the config for that dir (does not modify the parent dir).

[jbedard]

@walkerburgin another way of doing this if you want the file within a package would be the package.json "files" entry.

That is a bit different because it is what ships with a package, not with a "library", and it won't have rootDir/outDir applied to it like ts_project(assets).

Really I see this as complimentary features for slightly different purposes. WDYT? Do you see any clash or conflicts between those 2 things?