[Entry] Does not handle ownership/permission correctly

[Xynnn007]

Now when the entry is unpack(), the extracted file's ownership (gid, uid) and permission (mode) is not correctly handles compared to https://github.com/composefs/tar-rs/blob/main/src/entry.rs

Concretely,

1. symlink's permissions / ownership
2. directory's ownership
3. other file's ownership

[woodruffw]

Can you say more? Is the problem that we're not setting permissions on symlinks at all? And similarly for ownership on any extracted entries?

(In general, I'm not sure if we even want to support this, since (1) symlinks aren't allowed in Python distributions, and (2) the semantics of extracting anything from a distribution archive with anything other than the current user's uid/gid are unclear.)

[Xynnn007]

@woodruffw Hey. Sorry for not bringing details.

Is the problem that we're not setting permissions on symlinks at all? And similarly for ownership on any extracted entries?

Yes, this is the point.

(In general, I'm not sure if we even want to support this, since (1) symlinks aren't allowed in Python distributions, and (2) the semantics of extracting anything from a distribution archive with anything other than the current user's uid/gid are unclear.)

This is the case we met in docker image layer extracting. I think the UID/GID makes sense in that scenario. Thus for astral-tokio-tar, probably an option to control whether GID/UID is preserved can be good.

Also, I see the popular tar crate (sync version) supports this.