Skip to content

Commit 50285be

Browse files
author
makomo
committed
Stop checking NADC fixture byte sizes
1 parent 6f9424c commit 50285be

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

astroquery/nadc/tests/test_service_data.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,20 @@
1616

1717
NADC_ROOT = Path(__file__).parents[1]
1818
DATA_DIRS = sorted(NADC_ROOT.glob("*/tests/data"))
19+
TEXT_SUFFIXES = {".csv", ".json", ".xml"}
1920

2021

2122
def _sha256(path):
22-
return hashlib.sha256(path.read_bytes()).hexdigest()
23+
content = path.read_bytes()
24+
if path.suffix in TEXT_SUFFIXES:
25+
content = content.replace(b"\r\n", b"\n")
26+
return hashlib.sha256(content).hexdigest()
27+
28+
29+
def test_sha256_normalizes_text_newlines(tmp_path):
30+
path = tmp_path / "fixture.json"
31+
path.write_bytes(b'{"ok": true}\r\n')
32+
assert _sha256(path) == hashlib.sha256(b'{"ok": true}\n').hexdigest()
2333

2434

2535
@pytest.mark.parametrize("data_dir", DATA_DIRS, ids=lambda path: path.parts[-3])
@@ -34,7 +44,6 @@ def test_service_data_manifest_matches_files(data_dir):
3444

3545
for filename, metadata in manifest["files"].items():
3646
path = data_dir / filename
37-
assert path.stat().st_size == metadata["bytes"]
3847
assert _sha256(path) == metadata["sha256"]
3948

4049

0 commit comments

Comments
 (0)