Commit 44f105a
committed
fix(catalog,tests): address PR #196 review (Copilot)
Three valid review findings, all verified before acting:
- test_plugins_cli.py: synthetic catalog fixtures used data_source "Custom",
which now violates the tightened catalog_entry.schema.json enum. This was
not merely cosmetic: in test_validate_rejects_duplicate_accession_within_catalog
the per-entry schema failure short-circuited (validate_cmd `continue`s on a
schema error) so the duplicate-accession branch was never reached -- the test
passed for the wrong reason. Use a valid enum value ("ClinGen"); verified the
dedup branch is exercised again ("duplicate accession within catalog: DUP").
- test_unified_registry_per_plugin.py: same "Custom" -> "ClinGen" in the two
fake-entry fixtures, to keep examples consistent with the schema (the registry
loader doesn't schema-validate, so behavior is unchanged).
- gwas_catalog/catalog/datasets.json: the file description claimed "pinned
content: e115 / r2026-04-27" while the url is the rolling releases/latest/
endpoint. Reworded to clarify the url is the latest-release endpoint (may
resolve to a newer release) and that the built-from release lives in accession.
Verified: full fast suite 1004 passed, 0 failed, 4 skipped.1 parent 444e0bc commit 44f105a
3 files changed
Lines changed: 5 additions & 5 deletions
File tree
- hvantk
- skills/gwas_catalog/catalog
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
| 105 | + | |
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
| 140 | + | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
| |||
0 commit comments