test(e2e): delete MantleBackups after backup-failure tests to avoid interfering with subsequent tests

The test "should handle removal of MantleBackup in secondary k8s cluster
during an incremental backup" was failing with a timeout.

When the previous test (primary MantleBackup deletion scenario) finishes, a
residual secondary MantleBackup is left behind in "waiting for export
data" state because its primary was deleted before the upload completed. When
the next test pauses RGW, the secondary reconciler gets blocked on S3
operations triggered by processing this residual MantleBackup, causing
`kubectl delete --timeout=3m` issued against the current test's secondary
MantleBackup to expire before finalizeSecondary could run.

Add CleanupMantleBackups to delete all MantleBackups on both clusters at the
end of each backup-failure test via DeferCleanup, so that no residual
MantleBackups remain when the next test starts.

Signed-off-by: Kohya Shiozaki <kouyan120706@gmail.com>

Author: skoya76

test/e2e/multik8s/backup_failure_test.go

@@ -13,6 +13,7 @@ var _ = Describe("backup failure", Label("backup-failure"), func() {
 		pvcName := util.GetUniqueName("pvc-")
 		backupName := util.GetUniqueName("mb-")
 
+		DeferCleanup(func() { CleanupMantleBackups(namespace) })
 		SetupEnvironment(namespace)
 
 		// Pause the object storage to make backups fail.
@@ -54,6 +55,7 @@ var _ = Describe("backup failure", Label("backup-failure"), func() {
 		backupName := util.GetUniqueName("mb-")
 		restoreName := util.GetUniqueName("mr-")
 
+		DeferCleanup(func() { CleanupMantleBackups(namespace) })
 		SetupEnvironment(namespace)
 
 		// Pause the object storage to make backups fail.
@@ -105,6 +107,7 @@ var _ = Describe("backup failure", Label("backup-failure"), func() {
 			backupName1 := util.GetUniqueName("mb-")
 			restoreName0 := util.GetUniqueName("mr-")
 
+			DeferCleanup(func() { CleanupMantleBackups(namespace) })
 			SetupEnvironment(namespace)
 
 			// Create MantleBackup M0.
@@ -157,6 +160,7 @@ var _ = Describe("backup failure", Label("backup-failure"), func() {
 			restoreName0 := util.GetUniqueName("mr-")
 			restoreName1 := util.GetUniqueName("mr-")
 
+			DeferCleanup(func() { CleanupMantleBackups(namespace) })
 			SetupEnvironment(namespace)
 
 			// Create MantleBackup M0.

test/e2e/multik8s/testutil/util.go

@@ -486,6 +486,16 @@ func SetupEnvironment(namespace string) {
 	}).Should(Succeed())
 }
 
+func CleanupMantleBackups(namespace string) {
+	GinkgoHelper()
+	_, _, err := Kubectl(PrimaryK8sCluster, nil,
+		"delete", "mantlebackup", "--all", "-n", namespace, "--timeout=5m", "--ignore-not-found")
+	Expect(err).NotTo(HaveOccurred())
+	_, _, err = Kubectl(SecondaryK8sCluster, nil,
+		"delete", "mantlebackup", "--all", "-n", namespace, "--timeout=5m", "--ignore-not-found")
+	Expect(err).NotTo(HaveOccurred())
+}
+
 func CreatePod(cluster int, namespace, podName, pvcName string) {
 	GinkgoHelper()
 	err := applyPodMountVolumeTemplate(cluster, namespace, podName, pvcName)