tests for verify method

Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>

Author: llamerada-jp

Makefile

@@ -81,6 +81,7 @@ vet: ## Run go vet against code.
 
 .PHONY: mock
 mock: mockgen
+	$(MOCKGEN) -source=internal/ceph/ceph.go -destination=internal/ceph/ceph_mock.go -package=ceph
 	$(MOCKGEN) -source=internal/ceph/command.go -destination=internal/ceph/command_mock.go -package=ceph
 	$(MOCKGEN) -source=pkg/controller/proto/controller_grpc.pb.go -destination=pkg/controller/proto/controller_grpc.pb_mock.go -package=proto
 	$(MOCKGEN) -source=internal/controller/internal/objectstorage/objectstorage.go -destination=internal/controller/internal/objectstorage/objectstorage_mock.go -package=objectstorage

internal/ceph/ceph_mock.go

@@ -657,6 +657,7 @@ func (r *MantleBackupReconciler) verify(
 		},
 		makeVerifyPVName(backup),
 		labelComponentVerifyVolume,
+		true,
 	); err != nil {
 		return fmt.Errorf("failed to create a static PV with the clone: %w", err)
 	}
@@ -2070,6 +2071,7 @@ func (r *MantleBackupReconciler) reconcileZeroOutJob(
 		snapshotTarget.pv.Spec.Capacity,
 		MakeZeroOutPVName(backup),
 		labelComponentZeroOutVolume,
+		false,
 	); err != nil {
 		return ctrl.Result{}, err
 	}
@@ -2110,6 +2112,7 @@ func (r *MantleBackupReconciler) reconcileZeroOutJob(
 //	capacity      - resource capacity for the PV
 //	newPvName     - name for the new or updated PV
 //	componentName - label value for the component
+//	addFlatten    - whether to add deep-flatten feature to the volume attributes
 //
 // Returns an error if creation or update fails.
 func (r *MantleBackupReconciler) createOrUpdateStaticPV(
@@ -2118,6 +2121,7 @@ func (r *MantleBackupReconciler) createOrUpdateStaticPV(
 	volume string,
 	capacity corev1.ResourceList,
 	newPvName, componentName string,
+	addFlatten bool,
 ) error {
 	var pv corev1.PersistentVolume
 	pv.SetName(newPvName)
@@ -2149,8 +2153,16 @@ func (r *MantleBackupReconciler) createOrUpdateStaticPV(
 		if pv.Spec.CSI.VolumeAttributes == nil {
 			pv.Spec.CSI.VolumeAttributes = map[string]string{}
 		}
+		feature := basePV.Spec.CSI.VolumeAttributes["imageFeatures"]
+		if addFlatten {
+			if len(feature) > 0 {
+				feature = feature + ",deep-flatten"
+			} else {
+				feature = "deep-flatten"
+			}
+		}
 		pv.Spec.CSI.VolumeAttributes["clusterID"] = basePV.Spec.CSI.VolumeAttributes["clusterID"]
-		pv.Spec.CSI.VolumeAttributes["imageFeatures"] = basePV.Spec.CSI.VolumeAttributes["imageFeatures"]
+		pv.Spec.CSI.VolumeAttributes["imageFeatures"] = feature
 		pv.Spec.CSI.VolumeAttributes["imageFormat"] = basePV.Spec.CSI.VolumeAttributes["imageFormat"]
 		pv.Spec.CSI.VolumeAttributes["pool"] = basePV.Spec.CSI.VolumeAttributes["pool"]
 		pv.Spec.CSI.VolumeAttributes["staticVolume"] = "true"
@@ -2308,7 +2320,7 @@ func (r *MantleBackupReconciler) createOrUpdateVerifyJob(ctx context.Context, jo
 				Name:  "verify",
 				Image: r.podImage,
 				Command: []string{
-					"/user/sbin/e2fsck",
+					"/usr/sbin/e2fsck",
 					"-fn",
 					"/dev/verify-rbd",
 				},