update requeue parameter

`ctrl.Result{Requeue: true}` is influenced by backing off. We want
to avoid it.

Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>

Author: llamerada-jp

Makefile

@@ -90,7 +90,7 @@ mock: mockgen
 test: manifests generate fmt vet mock ## Run tests.
 # adding -p 1 -v to stream logs. see https://github.com/golang/go/issues/46959
 	ENVTEST_KUBERNETES_VERSION=$(ENVTEST_KUBERNETES_VERSION) ENVTEST_BIN_DIR=$(LOCALBIN) \
-	SKIP_CEPH_CMD_TEST=1 \
+	SKIP_CEPH_CMD_TEST=1 REQUEUE_RECONCILIATION_AFTER=10s \
 	go test ./... -coverprofile cover.out -p 1 -v
 
 GOLANGCI_LINT = $(shell pwd)/bin/golangci-lint

internal/controller/util.go

@@ -152,11 +152,11 @@ func IsJobConditionTrue(conditions []batchv1.JobCondition, conditionType batchv1
 func requeueReconciliation() ctrl.Result {
 	requeueAfter := os.Getenv("REQUEUE_RECONCILIATION_AFTER")
 	if requeueAfter != "" {
-		duration, err := time.ParseDuration(requeueAfter)
-		if err != nil {
-			panic(fmt.Sprintf("set REQUEUE_RECONCILIATION_AFTER properly: %v", err))
-		}
-		return ctrl.Result{RequeueAfter: duration}
+		panic("You should set REQUEUE_RECONCILIATION_AFTER env var.")
+	}
+	duration, err := time.ParseDuration(requeueAfter)
+	if err != nil {
+		panic(fmt.Sprintf("Set REQUEUE_RECONCILIATION_AFTER properly: %v", err))
 	}
-	return ctrl.Result{Requeue: true}
+	return ctrl.Result{RequeueAfter: duration}
 }

test/e2e/testdata/values-mantle-secondary-template.yaml

@@ -13,8 +13,8 @@ controller:
   envSecret: export-data
   gcInterval: 1s
   env:
-    - name: REQUEUE_RECONCILIATION_IMMEDIATELY
-      value: "1"
+    - name: REQUEUE_RECONCILIATION_AFTER
+      value: "10s"
   mtls:
     clientCACertConfigMap: mantle-primary-ca-crt
     serverTLSSecret: cert-mantle-replication