e2e: clean up namespaces after backup-failure tests to avoid interfering with subsequent tests

The test "should handle removal of MantleBackup in secondary k8s cluster during
an incremental backup" was failing with a timeout.

When the previous test (primary MantleBackup deletion scenario) finishes, a
residual secondary MantleBackup is left behind in "waiting for export data"
state because its primary was deleted before the upload completed. When the
next test pauses RGW, the secondary reconciler gets blocked on S3 operations
triggered by processing this residual MantleBackup, causing `kubectl delete
--timeout=3m` issued against the current test's secondary MantleBackup to
expire before finalizeSecondary could run.

Delete both primary and secondary namespaces at the end of each backup-failure
test via DeferCleanup, so that no residual MantleBackups remain when the next
test starts.

Signed-off-by: Kohya Shiozaki <kouyan120706@gmail.com>

Author: skoya76

test/e2e/multik8s/backup_failure_test.go

@@ -14,6 +14,7 @@ var _ = Describe("backup failure", Label("backup-failure"), func() {
 		backupName := util.GetUniqueName("mb-")
 
 		SetupEnvironment(namespace)
+		DeferCleanup(func() { TearDownEnvironment(namespace) })
 
 		// Pause the object storage to make backups fail.
 		PauseObjectStorage(ctx)
@@ -55,6 +56,7 @@ var _ = Describe("backup failure", Label("backup-failure"), func() {
 		restoreName := util.GetUniqueName("mr-")
 
 		SetupEnvironment(namespace)
+		DeferCleanup(func() { TearDownEnvironment(namespace) })
 
 		// Pause the object storage to make backups fail.
 		PauseObjectStorage(ctx)
@@ -106,6 +108,7 @@ var _ = Describe("backup failure", Label("backup-failure"), func() {
 			restoreName0 := util.GetUniqueName("mr-")
 
 			SetupEnvironment(namespace)
+			DeferCleanup(func() { TearDownEnvironment(namespace) })
 
 			// Create MantleBackup M0.
 			CreatePVC(ctx, PrimaryK8sCluster, namespace, pvcName)
@@ -158,6 +161,7 @@ var _ = Describe("backup failure", Label("backup-failure"), func() {
 			restoreName1 := util.GetUniqueName("mr-")
 
 			SetupEnvironment(namespace)
+			DeferCleanup(func() { TearDownEnvironment(namespace) })
 
 			// Create MantleBackup M0.
 			CreatePVC(ctx, PrimaryK8sCluster, namespace, pvcName)

test/e2e/multik8s/testutil/util.go

@@ -486,6 +486,14 @@ func SetupEnvironment(namespace string) {
 	}).Should(Succeed())
 }
 
+func TearDownEnvironment(namespace string) {
+	GinkgoHelper()
+	_, _, err := Kubectl(PrimaryK8sCluster, nil, "delete", "namespace", namespace, "--ignore-not-found")
+	Expect(err).NotTo(HaveOccurred())
+	_, _, err = Kubectl(SecondaryK8sCluster, nil, "delete", "namespace", namespace, "--ignore-not-found")
+	Expect(err).NotTo(HaveOccurred())
+}
+
 func CreatePod(cluster int, namespace, podName, pvcName string) {
 	GinkgoHelper()
 	err := applyPodMountVolumeTemplate(cluster, namespace, podName, pvcName)