Fix neverReadyReplicas calculation for clone processes

elderapo · elderapo · commit 11ceab0564ff · 2026-02-19T17:35:26.000+01:00
diff --git a/clustering/operations.go b/clustering/operations.go
@@ -534,15 +534,22 @@ func (p *managerProcess) configurePrimary(ctx context.Context, ss *StatusSet) (r
 			continue
 		}
 		if ist == nil {
+			// This happens during provisioning new pod
 			neverReadyReplicas++
 			continue
 		}
 
 		rs := ist.ReplicaStatus
 		if rs == nil {
+			// This happens when new secondary is cloning, uncofrunately `ist.CloneStatus` does not seem to be realible for these checks...
+			neverReadyReplicas++
 			continue
 		}
-		if rs.ReplicaIORunning != "Yes" || rs.ReplicaSQLRunning != "Yes" {
+
+		// log.Info("DUMPING IST BECAUSE OTHER CHECKS DID NOT HIT!",
+		// 	"ist", spew.Sdump(ist))
+
+		if !rs.IsRunning() {
 			continue
 		}
 		if !rs.SecondsBehindSource.Valid || rs.SecondsBehindSource.Int64 >= 10 {

Original file line number	Diff line number	Diff line change
`@@ -534,15 +534,22 @@ func (p managerProcess) configurePrimary(ctx context.Context, ss StatusSet) (r`
`534`	`534`	`continue`
`535`	`535`	`}`
`536`	`536`	`if ist == nil {`
	`537`	`+ // This happens during provisioning new pod`
`537`	`538`	`neverReadyReplicas++`
`538`	`539`	`continue`
`539`	`540`	`}`
`540`	`541`
`541`	`542`	`rs := ist.ReplicaStatus`
`542`	`543`	`if rs == nil {`
	`544`	+ // This happens when new secondary is cloning, uncofrunately `ist.CloneStatus` does not seem to be realible for these checks...
	`545`	`+ neverReadyReplicas++`
`543`	`546`	`continue`
`544`	`547`	`}`
`545`		`- if rs.ReplicaIORunning != "Yes" \|\| rs.ReplicaSQLRunning != "Yes" {`
	`548`	`+`
	`549`	`+ // log.Info("DUMPING IST BECAUSE OTHER CHECKS DID NOT HIT!",`
	`550`	`+ // "ist", spew.Sdump(ist))`
	`551`	`+`
	`552`	`+ if !rs.IsRunning() {`
`546`	`553`	`continue`
`547`	`554`	`}`
`548`	`555`	`if !rs.SecondsBehindSource.Valid \|\| rs.SecondsBehindSource.Int64 >= 10 {`