speedup Reconciler initialization using field indexer

Author: arosh

controllers/mysqlcluster_controller.go

@@ -1962,38 +1962,45 @@ func (r *MySQLClusterReconciler) SetupWithManager(ctx context.Context, mgr ctrl.
 		}
 	})
 
-	configMapHandler := handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, a client.Object) []reconcile.Request {
+	requestsForIndexedClusters := func(ctx context.Context, namespace, field, value string) []reconcile.Request {
 		clusters := &mocov1beta2.MySQLClusterList{}
-		if err := r.List(ctx, clusters, client.InNamespace(a.GetNamespace())); err != nil {
+		if err := r.List(ctx, clusters, client.InNamespace(namespace), client.MatchingFields{field: value}); err != nil {
 			return nil
 		}
-		var req []reconcile.Request
+
+		req := make([]reconcile.Request, 0, len(clusters.Items))
 		for _, c := range clusters.Items {
-			if c.Spec.MySQLConfigMapName == nil {
-				continue
-			}
-			if *c.Spec.MySQLConfigMapName == a.GetName() {
-				req = append(req, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(&c)})
-			}
+			req = append(req, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(&c)})
 		}
 		return req
-	})
+	}
 
-	backupPolicyHandler := handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, a client.Object) []reconcile.Request {
-		clusters := &mocov1beta2.MySQLClusterList{}
-		if err := r.List(ctx, clusters, client.InNamespace(a.GetNamespace())); err != nil {
+	if err := mgr.GetFieldIndexer().IndexField(ctx, &mocov1beta2.MySQLCluster{}, "spec.mysqlConfigMapName", func(rawObj client.Object) []string {
+		c := rawObj.(*mocov1beta2.MySQLCluster)
+		if c.Spec.MySQLConfigMapName == nil {
 			return nil
 		}
-		var req []reconcile.Request
-		for _, c := range clusters.Items {
-			if c.Spec.BackupPolicyName == nil {
-				continue
-			}
-			if *c.Spec.BackupPolicyName == a.GetName() {
-				req = append(req, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(&c)})
-			}
+		return []string{*c.Spec.MySQLConfigMapName}
+	}); err != nil {
+		return fmt.Errorf("failed to index MySQLCluster by spec.mysqlConfigMapName: %w", err)
+	}
+
+	configMapHandler := handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, a client.Object) []reconcile.Request {
+		return requestsForIndexedClusters(ctx, a.GetNamespace(), "spec.mysqlConfigMapName", a.GetName())
+	})
+
+	if err := mgr.GetFieldIndexer().IndexField(ctx, &mocov1beta2.MySQLCluster{}, "spec.backupPolicyName", func(rawObj client.Object) []string {
+		c := rawObj.(*mocov1beta2.MySQLCluster)
+		if c.Spec.BackupPolicyName == nil {
+			return nil
 		}
-		return req
+		return []string{*c.Spec.BackupPolicyName}
+	}); err != nil {
+		return fmt.Errorf("failed to index MySQLCluster by spec.backupPolicyName: %w", err)
+	}
+
+	backupPolicyHandler := handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, a client.Object) []reconcile.Request {
+		return requestsForIndexedClusters(ctx, a.GetNamespace(), "spec.backupPolicyName", a.GetName())
 	})
 
 	return ctrl.NewControllerManagedBy(mgr).