Tighten CredentialRotation API per kube-api-linter

Surface a couple of guardrails that kube-api-linter (KAL) flagged
on the new types:

- Add an explicit MaxLength=36 on status.rotationID. The existing
  Pattern constrains the value to a canonical UUID, but MaxLength
  is the convention KAL expects and also limits the OpenAPI/CRD
  schema explicitly.
- Promote the Conditions field's SSA tags (patchStrategy=merge,
  patchMergeKey=type) into godoc markers in addition to the
  struct tag. This matches the modern style upstream Kubernetes
  uses on metav1.Condition slices and what KAL recommends.

Remaining KAL findings on the rest of the v1beta2 API (godoc
should start with the json field name, +default vs
+kubebuilder:default, etc.) are pre-existing project-wide and
are not addressed here to avoid churn unrelated to this PR.

Signed-off-by: shunki-fujita <shunki-fujita@cybozu.co.jp>

Author: shunki-fujita

api/v1beta2/credentialrotation_types.go

@@ -43,12 +43,16 @@ type CredentialRotationStatus struct {
 	// for canonical Type/Reason definitions.
 	// +listType=map
 	// +listMapKey=type
+	// +patchStrategy=merge
+	// +patchMergeKey=type
 	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"`
 
 	// RotationID is the UUID for the in-flight rotation cycle.
-	// Empty when no cycle is active.
+	// Empty when no cycle is active. The value, if non-empty, is a
+	// canonical 36-character UUID.
 	// +kubebuilder:validation:Pattern=`^([0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12})?$`
+	// +kubebuilder:validation:MaxLength=36
 	// +optional
 	RotationID string `json:"rotationID,omitempty"`
 

charts/moco/templates/generated/crds/moco_crds.yaml

@@ -2906,6 +2906,7 @@ spec:
                   type: integer
                 rotationID:
                   description: RotationID is the UUID for the in-flight rotation...
+                  maxLength: 36
                   pattern: ^([0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12})?$
                   type: string
               type: object

config/crd/bases/moco.cybozu.com_credentialrotations.yaml

@@ -142,6 +142,7 @@ spec:
                 type: integer
               rotationID:
                 description: RotationID is the UUID for the in-flight rotation...
+                maxLength: 36
                 pattern: ^([0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12})?$
                 type: string
             type: object

config/crd/tests/apiextensions.k8s.io_v1_customresourcedefinition_credentialrotations.moco.cybozu.com.yaml

@@ -141,6 +141,7 @@ spec:
                 type: integer
               rotationID:
                 description: RotationID is the UUID for the in-flight rotation...
+                maxLength: 36
                 pattern: ^([0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12})?$
                 type: string
             type: object