Merge remote-tracking branch 'origin/master' into feature/modern-theme-phase-2

Author: Mike Thompson

CHANGELOG.md

@@ -18,6 +18,9 @@
 
 ## 2.29.4 (Unreleased)
 
+#### Added
+- `popover`: full `:parts` & `:theme` support for all five popover components (`popover-title`, `popover-border`, `popover-content-wrapper`, `popover-anchor-wrapper`, `popover-tooltip`). Closes the gap called out in the 2.29.0 changelog ("Full `:parts` & `:theme` support for most components (excluding `popover`, `v-table` and `simple-v-table`)"). The classic look is preserved verbatim — every legacy CSS class (`rc-popover-border`, `popover`, `rc-popover-title`, `rc-popover-arrow`, `rc-popover-content`, `rc-popover-anchor-wrapper`, `rc-point-wrapper`, `rc-popover-point`, `rc-popover-tooltip`, etc.) is still applied via `bootstrap` theme methods. Form-3 lifecycle behaviour (refs, `:component-did-mount`, `:component-did-update`, position-optimization atoms) is unchanged; `theme/comp` is composed once at mount time per component instance.
+
 #### Fixed
 - `popover-anchor-wrapper`: `:popover` argument using positional-args calling style `[popover-fn arg1 arg2 ...]` no longer breaks `:showing-injected?`/`:position-injected` injection. Previously the non-keyword branch wrapped the call as a single map, causing the receiving fn's `[a b & {:keys [...]}]` destructure to bind `a` to the entire map and produce nil kwargs — visible as a 💥 in the "Complex Popover (dialog box)" demo. Map-style invocation `[popover-fn {props}]` continues to work. [#367](https://github.com/day8/re-com/issues/367)
 - `re-com.debug`: validation logger now reports `:validate-fn-return` problems with the validator's actual error message instead of an unhelpful "Unknown problem reported". This affected any validator built on `validate-arg-against-set` (e.g. `position?`, `justify-style?`, `alert-type?`) when a value didn't match the expected set — the error string was being computed but never shown. [#368](https://github.com/day8/re-com/issues/368)

demo/re_demo/popovers.cljs

@@ -105,7 +105,7 @@
                   [:tr
                    [:td border-style-nw (indent-text 2 "[:div]")]
                    [:td border-style-nw "rc-popover-point"]
-                   [:td border-style (code-text ":popover-point")]
+                   [:td border-style (code-text ":point")]
                    [:td border-style "The point (width/height 0) which is placed at the center of the relevant side of the anchor, based on " (code-text ":position") " arg."]]
                   [:tr
                    [:td border-style-nw (indent-text 3 (highlight-text ":popover"))]
@@ -130,12 +130,12 @@
                   [:tr
                    [:td border-style-nw (indent-text 5 "[popover-title]")]
                    [:td border-style-nw "popover-title"]
-                   [:td border-style (code-text ":title")]
+                   [:td border-style (code-text ":title-bar")]
                    [:td border-style "Optional based on " (code-text ":title") " arg. Adds a close button if " (code-text ":on-cancel") " arg is set."]]
                   [:tr
                    [:td border-style-nw (indent-text 5 "[:div]")]
                    [:td border-style-nw "popover-content"]
-                   [:td border-style ""]
+                   [:td border-style (code-text ":content")]
                    [:td border-style "Exists to override the default popover padding."]]
                   [:tr
                    [:td border-style-nw (indent-text 6 (highlight-text ":body"))]