Merge pull request #369 from day8/fix/popover-positional-args

Fix popover-anchor-wrapper for positional-args :popover style

Author: mike-thompson-day8

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.29.4 (Unreleased)
+
+#### Fixed
+- `popover-anchor-wrapper`: `:popover` argument using positional-args calling style `[popover-fn arg1 arg2 ...]` no longer breaks `:showing-injected?`/`:position-injected` injection. Previously the non-keyword branch wrapped the call as a single map, causing the receiving fn's `[a b & {:keys [...]}]` destructure to bind `a` to the entire map and produce nil kwargs — visible as a 💥 in the "Complex Popover (dialog box)" demo. Map-style invocation `[popover-fn {props}]` continues to work. [#367](https://github.com/day8/re-com/issues/367)
+
 ## 2.29.3 (2026-04-29)
 
 #### Added

src/re_com/popover.cljs

@@ -578,7 +578,7 @@
             (let [[orientation _arrow-pos] (split-keyword @internal-position "-") ;; only need orientation here
                   place-anchor-before?    (case orientation (:left :above) false true)
                   flex-flow               (case orientation (:left :right) "row" "column")
-                  [popover-fn & {:as popover-args}] popover]
+                  popover-fn               (first popover)]
               [:div
                (merge {:class (theme/merge-class "rc-popover-anchor-wrapper"
                                                  "display-inline-flex"
@@ -607,12 +607,17 @@
                                    :z-index  4}
                                   (get-in parts [:point :style]))
                     :attr  (get-in parts [:point :attr])}
-                   (if (keyword? (get popover 1))
+                   (cond
+                     (keyword? (get popover 1))
                      (into popover [:showing-injected? showing?
                                     :position-injected internal-position])
-                     [popover-fn (merge popover-args
+                     (map? (get popover 1))
+                     [popover-fn (merge (get popover 1)
                                         {:showing-injected? showing?
-                                         :position-injected internal-position})])])
+                                         :position-injected internal-position})]
+                     :else
+                     (into popover [:showing-injected? showing?
+                                    :position-injected internal-position]))])
                 (when-not place-anchor-before? anchor)]]))))}))))
 
 ;;--------------------------------------------------------------------------------------------------