ete4 Newick parser read_props: local variable 'p1_str' referenced before assignment

[terrycojones]

Here's a simple error in ete4 v4.4.0:

import ete4
ete4.Tree("(A);", parser=3)

resulting in

python3.12/site-packages/ete4/parser/newick.pyx:239, in ete4.parser.newick.read_props()

UnboundLocalError: local variable 'p1_str' referenced before assignment

I don't understand the code well enough to suggest a fix but am happy to send a pull request if someone tells me what to do :-)

[dengzq1234]

hi, when parser=3, it means all support values of internal node must present, otherwise returns error. In your case, if ete4.Tree("(A)1.0;", parser=3), it will work. If you are not sure whether all internal nodes have support value, use default such as ete4.Tree("(A);")

Please find documentation about parser over here https://etetoolkit.github.io/ete/tutorial/tutorial_trees.html#reading-and-writing-newick-trees

Cheers

[terrycojones]

Hi @dengzq1234 Yes, thanks. I know that what I tried wasn't the right thing to do (I was trying different parsers to see if I could get anything to work on a much bigger tree). But when you say "otherwise returns error" I wouldn't have thought that would include having an UnboundLocalError exception being raised :-) That doesn't return an error, it just blows up.