Make schema file loaded callback success-only

Author: eviltester

packages/core-ui/js/gui_components/shared/schema-definition/shared-schema-definition-controller.js

@@ -214,11 +214,13 @@ class SharedSchemaDefinitionController {
       this.clearSchemaError();
       const schemaText = await fileTransferService.readSchemaTextFile(file);
       const result = this.loadSchemaText(schemaText, { showErrors: true, preferRowMode: true });
-      this.callbacks.onSchemaFileLoaded?.({
-        fileName: file.name || '',
-        schemaText,
-        result,
-      });
+      if (result?.applied !== false) {
+        this.callbacks.onSchemaFileLoaded?.({
+          fileName: file.name || '',
+          schemaText,
+          result,
+        });
+      }
       return result;
     } catch (error) {
       const message = `Unable to load schema file: ${error?.message || String(error)}`;

packages/core-ui/src/tests/shared/shared-schema-definition-controller.test.js

@@ -157,10 +157,14 @@ describe('SharedSchemaDefinitionController', () => {
     const schemaFileTransferService = {
       readSchemaTextFile: jest.fn(async () => 'Loaded Name\nliteral(Ada)'),
     };
+    const onSchemaFileLoaded = jest.fn();
     const controller = new SharedSchemaDefinitionController({
       services: {
         schemaFileTransferService,
       },
+      callbacks: {
+        onSchemaFileLoaded,
+      },
     });
     controller.schemaEditor = {
       loadSchemaText: jest.fn(() => ({ rows: [{ name: 'Loaded Name' }], errors: [], applied: true })),
@@ -179,6 +183,40 @@ describe('SharedSchemaDefinitionController', () => {
       errors: [],
       applied: true,
     });
+    expect(onSchemaFileLoaded).toHaveBeenCalledWith({
+      fileName: 'schema.txt',
+      schemaText: 'Loaded Name\nliteral(Ada)',
+      result: {
+        rows: [{ name: 'Loaded Name' }],
+        errors: [],
+        applied: true,
+      },
+    });
+  });
+
+  test('loadSchemaFromFile does not emit onSchemaFileLoaded when schema parsing fails', async () => {
+    const schemaFileTransferService = {
+      readSchemaTextFile: jest.fn(async () => 'Broken Name'),
+    };
+    const onSchemaFileLoaded = jest.fn();
+    const controller = new SharedSchemaDefinitionController({
+      services: {
+        schemaFileTransferService,
+      },
+      callbacks: {
+        onSchemaFileLoaded,
+      },
+    });
+    controller.schemaEditor = {
+      loadSchemaText: jest.fn(() => ({ rows: [], errors: [new Error('Missing value')], applied: false })),
+      getState: jest.fn(() => ({ rows: [{ name: 'Existing Name' }], tokens: [], isTextMode: false })),
+    };
+
+    const result = await controller.loadSchemaFromFile({ name: 'broken-schema.txt' });
+
+    expect(result.applied).toBe(false);
+    expect(result.errors).toHaveLength(1);
+    expect(onSchemaFileLoaded).not.toHaveBeenCalled();
   });
 
   test('loadSchemaFromFile surfaces wrapped file read failures with a useful message', async () => {