Description

metric_fn() in pytorch_hist.py (line 173) and pytorch_igmtf.py (line 166) uses == to compare self.metric against the tuple ("", "loss"):

if self.metric == ("", "loss"):
    return -self.loss_fn(pred[mask], label[mask])

Since self.metric is always a string (default is ""), this comparison is never true. The function falls through to raise ValueError("unknown metric").

All other models correctly use in:

# pytorch_alstm.py, pytorch_gru.py, pytorch_lstm.py, etc.
if self.metric in ("", "loss"):
    return -self.loss_fn(pred[mask], label[mask])

Impact

Any user training HIST or IGMTF with the default metric (or metric="loss") will get a crash:

ValueError: unknown metric ``

Fix

- if self.metric == ("", "loss"):
+ if self.metric in ("", "loss"):

I will submit a fix shortly.