Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

TypeScript errors when skipLibCheck is false #887

Description

@lo1tuma

I’ve noticed the d2c starter-kit sets the ts option skipLibCheck to true. No I’ve tried to use the moltin sdk in a different project where we haven’t set skipLibCheck to true and I get around 40 compile errors when running the typescript compile, all complain about the moltin.d.ts in the node_modules folder.

E.g.:

node_modules/@moltin/sdk/dist/moltin.d.ts:98:1 - error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

Is there any chance that you fix those errors, so we don’t have to disable lib check as this would degrade the accuracy of the type-system?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions