Skip to content

Commit e114fca

Browse files
committed
Still not correct!
1 parent d0ca9f2 commit e114fca

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

integration/bunjs-only-snippets/ffi.test.fixture.callback.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,9 +258,6 @@ void* JSFunctionCall(void* globalObject, void* callFrame);
258258
bool my_callback_function(void* arg0);
259259

260260
bool my_callback_function(void* arg0) {
261-
#ifdef INJECT_BEFORE
262-
INJECT_BEFORE;
263-
#endif
264261
EncodedJSValue arguments[1] = {
265262
PTR_TO_JSVALUE(arg0)
266263
};

src/javascript/jsc/bindings/JSBufferConstructorBuiltins.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ namespace WebCore {
4444

4545
const JSC::ConstructAbility s_jsBufferConstructorFromCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
4646
const JSC::ConstructorKind s_jsBufferConstructorFromCodeConstructorKind = JSC::ConstructorKind::None;
47-
const int s_jsBufferConstructorFromCodeLength = 936;
47+
const int s_jsBufferConstructorFromCodeLength = 1019;
4848
static const JSC::Intrinsic s_jsBufferConstructorFromCodeIntrinsic = JSC::NoIntrinsic;
4949
const char* const s_jsBufferConstructorFromCode =
5050
"(function (items) {\n" \
@@ -55,7 +55,7 @@ const char* const s_jsBufferConstructorFromCode =
5555
"\n" \
5656
"\n" \
5757
" //\n" \
58-
" if (typeof items === 'string' || ArrayBuffer.isView(items)) {\n" \
58+
" if (typeof items === 'string' || (typeof items === 'object' && items && (items instanceof ArrayBuffer || items instanceof SharedArrayBuffer))) {\n" \
5959
" switch (@argumentCount()) {\n" \
6060
" case 1: {\n" \
6161
" return new this(items);\n" \

src/javascript/jsc/bindings/builtins/js/JSBufferConstructor.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ function from(items) {
3434

3535

3636
// TODO: figure out why private symbol not found
37-
if (typeof items === 'string' || ArrayBuffer.isView(items)) {
37+
if (typeof items === 'string' || (typeof items === 'object' && items && (items instanceof ArrayBuffer || items instanceof SharedArrayBuffer))) {
3838
switch (@argumentCount()) {
3939
case 1: {
4040
return new this(items);

0 commit comments

Comments
 (0)