#3496 languagetool: fix crash when closing QOwnNotes while LanguageTool was active

Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>

Author: pbek

CHANGELOG.md

@@ -8,6 +8,9 @@
   scans while typing when the backlink inputs did not change, and by computing
   backlink-relative note paths without touching every note file on disk
   (for [#3587](https://github.com/pbek/QOwnNotes/issues/3587))
+- Fixed a crash when closing QOwnNotes while **LanguageTool** was active by
+  clearing checker state without triggering editor rehighlighting during text
+  edit destruction (for [#3496](https://github.com/pbek/QOwnNotes/issues/3496))
 
 ## 26.6.3
 

src/services/harperchecker.cpp

@@ -68,15 +68,15 @@ void HarperChecker::setTextEdit(QPlainTextEdit *textEdit) {
     scheduleCheck(true);
 }
 
-void HarperChecker::clearForTextEdit(QPlainTextEdit *textEdit) {
+void HarperChecker::clearForTextEdit(QPlainTextEdit *textEdit, bool updateBlocks) {
     if (_textEdit == textEdit) {
-        clearCurrentState();
+        clearCurrentState(updateBlocks);
         _textEdit.clear();
         _document.clear();
     }
 }
 
-void HarperChecker::clearCurrentState() {
+void HarperChecker::clearCurrentState(bool updateBlocks) {
     _debounceTimer->stop();
     _client->cancelAllRequests();
     _pendingRequests.clear();
@@ -88,7 +88,9 @@ void HarperChecker::clearCurrentState() {
     if (oldAvailable != _available) {
         Q_EMIT availabilityChanged(_available);
     }
-    Q_EMIT blockMatchesUpdated(QVector<int>());
+    if (updateBlocks) {
+        Q_EMIT blockMatchesUpdated(QVector<int>());
+    }
 }
 
 void HarperChecker::invalidateBlock(int blockNumber) { _cache.remove(blockNumber); }

src/services/harperchecker.h

@@ -31,8 +31,8 @@ class HarperChecker : public QObject {
     static HarperChecker *instance();
 
     void setTextEdit(QPlainTextEdit *textEdit);
-    void clearForTextEdit(QPlainTextEdit *textEdit);
-    void clearCurrentState();
+    void clearForTextEdit(QPlainTextEdit *textEdit, bool updateBlocks = true);
+    void clearCurrentState(bool updateBlocks = true);
     void invalidateBlock(int blockNumber);
     void scheduleCheck(bool immediate = false);
     void recheckNow();

src/services/languagetoolchecker.cpp

@@ -70,22 +70,24 @@ void LanguageToolChecker::setTextEdit(QPlainTextEdit *textEdit) {
     scheduleCheck(true);
 }
 
-void LanguageToolChecker::clearForTextEdit(QPlainTextEdit *textEdit) {
+void LanguageToolChecker::clearForTextEdit(QPlainTextEdit *textEdit, bool updateBlocks) {
     if (_textEdit == textEdit) {
-        clearCurrentState();
+        clearCurrentState(updateBlocks);
         _textEdit.clear();
         _document.clear();
     }
 }
 
-void LanguageToolChecker::clearCurrentState() {
+void LanguageToolChecker::clearCurrentState(bool updateBlocks) {
     _debounceTimer->stop();
     _client->cancelAllRequests();
     _pendingRequests.clear();
     _pendingRequestId = 0;
     _cache.clear();
     _warningShown = false;
-    Q_EMIT blockMatchesUpdated(QVector<int>());
+    if (updateBlocks) {
+        Q_EMIT blockMatchesUpdated(QVector<int>());
+    }
 }
 
 void LanguageToolChecker::invalidateBlock(int blockNumber) { _cache.remove(blockNumber); }

src/services/languagetoolchecker.h

@@ -30,8 +30,8 @@ class LanguageToolChecker : public QObject {
     static LanguageToolChecker *instance();
 
     void setTextEdit(QPlainTextEdit *textEdit);
-    void clearForTextEdit(QPlainTextEdit *textEdit);
-    void clearCurrentState();
+    void clearForTextEdit(QPlainTextEdit *textEdit, bool updateBlocks = true);
+    void clearCurrentState(bool updateBlocks = true);
     void invalidateBlock(int blockNumber);
     void scheduleCheck(bool immediate = false);
     void recheckNow();

src/widgets/qownnotesmarkdowntextedit.cpp

@@ -3619,10 +3619,10 @@ QOwnNotesMarkdownTextEdit::~QOwnNotesMarkdownTextEdit() {
     qDebug() << "*** QOwnNotesMarkdownTextEdit DESTROYED ***" << this << objectName();
     closeMarkdownLspDocument();
 #ifdef LANGUAGETOOL_ENABLED
-    LanguageToolChecker::instance()->clearForTextEdit(this);
+    LanguageToolChecker::instance()->clearForTextEdit(this, false);
 #endif
 #ifdef HARPER_ENABLED
-    HarperChecker::instance()->clearForTextEdit(this);
+    HarperChecker::instance()->clearForTextEdit(this, false);
 #endif
     // Unregister if this was the active editor
     unregisterAsActiveEditor();