Skip to content

[Bug] Allow Editing and Deletion of Experimental Groups Not Linked to Any Samples #1404

Description

@Steffengreiner

What actually happened?

When samples are registered in an experiment, the edit and delete controls for experimental groups become disabled, regardless of whether a given group is actually linked to any samples.
A user adding a new group after sample registration cannot edit or delete that group, even though it has no sample associations.

What did you expect to happen?

Experimental groups that are not linked to any samples remain editable and deletable, even when other groups in the same experiment do have samples registered. Only experimental groups that have at least one sample assigned to them are non-editable and deleteable.

Steps to reproduce

Step by Step guide

On the Experiment View inside an experiment with samples attached, I performed the following steps.

1.) Click the experimental group tab
2.) Click the add button to open the add experimental group dialog
3.) Fill in the group variables name and level
4.) Trigger the experimental group creation by pressing the add button in the experimental group creation dialog
5.) Observe the newly created experimental group
6.) Click the edit button to try to open the edit experimental group
7.) Get notified that the groups cannot be edited due to samples being registered within the experiment

Video

544450622-90e6027a-024f-4e3c-acb3-d685655f6d87.mp4

Affected application area

Experiment Management

Browser(s) where the problem occurs

Firefox

Additional context

Acceptance Criteria

  • Given an experiment has registered samples, when the user views the experimental groups, then groups with no linked samples have their edit and delete controls enabled.
  • Given an experimental group has at least one sample linked to it, when the user views that group, then the edit and delete controls for that group are disabled.
  • Given a user with at least write permissions within the project edits an unlinked experimental group, when they save changes (e.g. correcting the name or conditions), then the changes are persisted and reflected in the UI.
  • Given a user with at least write permissions within the project deletes an unlinked experimental group, when they confirm the deletion, then the group is removed and no longer appears in the experiment.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsprint:currentIssue is part of the current sprintstale

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Todo
    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions