Skip to content

Commit 9d0ddbd

Browse files
authored
feat(config): set groupSingleUpdates=false by default (#44168)
* feat(config): set `groupSingleUpdates=false` by default Although it didn't seem like this may be a breaking change when we introduced this[0], there have been a number of follow-up Discussions reported that have indicated there has been some breakage from the changes. Instead of continually fixing forward, we can revert this back to an opt-in feature. Once it's stable, we can look at re-enabling it (most likely in a major release, unless we're confident no breakage should occur). [0]: #43629 (comment) * fixup! feat(config): set `groupSingleUpdates=false` by default
1 parent a0df771 commit 9d0ddbd

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

docs/usage/configuration-options.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2032,7 +2032,8 @@ For example, to group all non-major devDependencies updates together into a sing
20322032

20332033
## `groupSingleUpdates`
20342034

2035-
For example, you can set it to `false` if you prefer individual dependency names in PR titles when only one update is in the group.
2035+
!!! note
2036+
This option was [recently made opt-in, instead of opt-out](https://github.com/renovatebot/renovate/pull/44168).
20362037

20372038
## `groupSlug`
20382039

lib/config/options/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2617,7 +2617,7 @@ const options: Readonly<RenovateOptions>[] = [
26172617
description:
26182618
'Apply group settings even when the group contains only one update.',
26192619
type: 'boolean',
2620-
default: true,
2620+
default: false,
26212621
cli: false,
26222622
env: false,
26232623
},

lib/workers/repository/updates/generate.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ beforeEach(() => {
2828

2929
describe('workers/repository/updates/generate', () => {
3030
describe('generateBranchConfig()', () => {
31-
it('groups single upgrade by default', () => {
31+
it('does not group single upgrade by default', () => {
3232
const { groupSingleUpdates } = getConfig();
3333
const branch = [
3434
{
@@ -47,10 +47,10 @@ describe('workers/repository/updates/generate', () => {
4747
},
4848
] satisfies BranchUpgradeConfig[];
4949
const res = generateBranchConfig(branch);
50-
expect(res.groupName).toBe('some-group');
51-
expect(res.isGroup).toBeTrue();
52-
expect(res.recreateClosed).toBeTrue();
53-
expect(res.commitMessageExtra).toBeUndefined();
50+
expect(res.groupName).toBeUndefined();
51+
expect(res.isGroup).toBeUndefined();
52+
expect(res.recreateClosed).toBeFalse();
53+
expect(res.commitMessageExtra).toEqual('to 1.2.3');
5454
});
5555

5656
it('groups single upgrade across multiple files', () => {

0 commit comments

Comments
 (0)