Onboarding seems to fail due to missing config

[bidorffOL]

How are you running Renovate?

None

Which platform you running Renovate on?

GitLab (.com or self-hosted)

Which version of Renovate are you using?

43.233.0

Please tell us more about your question or problem

Hello,

It seems that the PR #44098 unfortunately breaks the onboarding process:

DEBUG: findPr(renovate/configure, undefined, open) (repository=xxxx)
DEBUG: Filling in onboarding PR template (repository=xxxx)
ERROR: Repository has unknown error (repository=xxxx)
       "err": {"message": "Cannot read properties of undefined (reading 'homepage')"}
       TypeError: Cannot read properties of undefined (reading 'homepage')
           at ensureOnboardingPr (file:///usr/local/renovate/lib/workers/repository/onboarding/pr/index.ts:141:26)
           at processTicksAndRejections (node:internal/process/task_queues:104:5)
           at renovateRepository (file:///usr/local/renovate/lib/workers/repository/index.ts:132:9)
           at instrument.attributes (file:///usr/local/renovate/lib/workers/global/index.ts:235:11)
           at start (file:///usr/local/renovate/lib/workers/global/index.ts:220:7)
           at file:///usr/local/renovate/lib/renovate.ts:26:22

After some investing, I saw that the productLinks default configuration is missing starting from 43.232.1 (see the attached logs). Unfortunately, this is my first time using renovate and I'm afraid I lack experience to help further in the investigation on my own, I hope this will help the troubleshooting though.

Logs (if relevant)

Logs (version 43.232.1)

 INFO: Renovate started
       "renovateVersion": "43.232.1"
 INFO: Repository started (repository=local)
       "renovateVersion": "43.232.1"
 INFO: Full resolved config and hostRules including presets (repository=local)
       "config": {
         "mode": "full",
         "detectGlobalManagerConfig": false,
         "detectHostRulesFromEnv": false,
         "useCloudMetadataServices": true,
         "bumpVersions": [],
         "postUpgradeTasks": {
           "commands": [],
           "fileFilters": [],
           "executionMode": "update",
           "installTools": {}
         },
         "configMigration": true,
         "statusCheckNames": {
           "artifactError": "renovate/artifacts",
           "configValidation": "renovate/config-validation",
           "mergeConfidence": "renovate/merge-confidence",
           "minimumReleaseAge": "renovate/stability-days"
         },
[...]

Logs (version 43.232.0)

  INFO: Renovate started
       "renovateVersion": "43.232.0"
 INFO: Repository started (repository=local)
       "renovateVersion": "43.232.0"
 INFO: Full resolved config and hostRules including presets (repository=local)
       "config": {
         "mode": "full",
         "detectGlobalManagerConfig": false,
         "detectHostRulesFromEnv": false,
         "useCloudMetadataServices": true,
         "bumpVersions": [],
         "postUpgradeTasks": {
           "commands": [],
           "fileFilters": [],
           "executionMode": "update",
           "installTools": {}
         },
         "configMigration": true,
         "productLinks": {
           "documentation": "https://docs.renovatebot.com/",
           "help": "https://github.com/renovatebot/renovate/discussions",
           "homepage": "https://github.com/renovatebot/renovate"
         },
         "statusCheckNames": {
           "artifactError": "renovate/artifacts",
           "configValidation": "renovate/config-validation",
           "mergeConfidence": "renovate/merge-confidence",
           "minimumReleaseAge": "renovate/stability-days"
         },
[...]

[krotname]

This looks like a regression from #44098 / 43.233.x, not a GitLab API problem.

The stack trace points at onboarding PR generation:

config.productLinks!.homepage

So Renovate is building the onboarding PR body, but config.productLinks is undefined. That explains why it happens during onboarding/configure branch creation before any normal dependency PRs are created.

Short-term workarounds:

1. pin back to the last 43.232.x image/version until a patch is released, or
2. if you can set global self-hosted config, define productLinks, e.g.

{
  "productLinks": {
    "homepage": "https://docs.renovatebot.com/",
    "documentation": "https://docs.renovatebot.com/"
  }
}

The actual code fix should probably avoid the non-null assertion and use GlobalConfig.get('productLinks') or a default before reading .homepage.

[JeffreyH89]

Hello,

I tried adding the suggestion above in our config.js. But this does not work

DEBUG: File config "config": { ], "hostRules": [{}], "productLinks": { "documentation": "[https://docs.renovatebot.com/",](https://docs.renovatebot.com/%22,) "help": "[https://github.com/renovatebot/renovate/discussions",](https://github.com/renovatebot/renovate/discussions%22,) "homepage": "[https://github.com/renovatebot/renovate"](https://github.com/renovatebot/renovate%22) },

"err": { "message": "Cannot read properties of undefined (reading 'homepage')", "stack": "TypeError: Cannot read properties of undefined (reading 'homepage')\n at ensureOnboardingPr (file:///C:/a/1/s/node_modules/renovate/lib/workers/repository/onboarding/pr/index.ts:141:26)\n at processTicksAndRejections (node:internal/process/task_queues:104:5)\n at renovateRepository (file:///C:/a/1/s/node_modules/renovate/lib/workers/repository/index.ts:132:9)\n at instrument.attributes (file:///C:/a/1/s/node_modules/renovate/lib/workers/global/index.ts:235:11)\n at start (file:///C:/a/1/s/node_modules/renovate/lib/workers/global/index.ts:220:7)\n at file:///C:/a/1/s/node_modules/renovate/lib/renovate.ts:26:22" },

The only solution for now is pinning Renovate to 43.232.0.

[JeffreyH89]

4.234.1 seems to have fixed this issue, thank you!

[jamietanna]

Yep, apologies for this, folks!

[weakcamel]

Thanks for the speedy fix, much appreciated!