Enable the type checker by default

Signed-off-by: Roberto Raggi <roberto.raggi@gmail.com>

Author: robertoraggi

.github/workflows/ci.yml

@@ -36,6 +36,7 @@ jobs:
           for i in src/parser/cxx/*.cc src/lsp/cxx/lsp/*.cc src/frontend/cxx/*.cc; do
             echo "Parsing $i"
             ./build/src/frontend/cxx \
+              -fno-check \
               -I src/parser \
               -I src/lsp \
               -I build/_deps/utfcpp-src/source \
@@ -52,6 +53,7 @@ jobs:
           for i in src/parser/cxx/*.cc src/lsp/cxx/lsp/*.cc src/frontend/cxx/*.cc; do
             echo "Parsing $i"
             ./build/src/frontend/cxx \
+              -fno-check \
               -toolchain linux \
               -I src/parser \
               -I src/lsp \
@@ -208,6 +210,7 @@ jobs:
           for i in src/parser/cxx/*.cc src/lsp/cxx/lsp/*.cc src/frontend/cxx/*.cc; do
             echo "Parsing $i"
             ./build/src/frontend/cxx \
+              -fno-check \
               -toolchain macos \
               -I src/parser \
               -I src/lsp \

scripts/build-emscripten.js

@@ -9,7 +9,7 @@ const __dirname = path.dirname(__filename);
 
 async function main() {
   // configure cmake using the emscripten presets
-  await $`cmake --preset emscripten`;
+  await $`cmake --preset emscripten-mlir`;
   await $`cmake --build --preset build-emscripten`;
 
   // make sure packages/cxx-frontend/dist/wasm exists

src/frontend/cxx/cxx.cc

@@ -39,6 +39,11 @@ auto main(int argc, char* argv[]) -> int {
     cli.opt_lsp = true;
   }
 
+  if (cli.opt_fno_check) {
+    cli.opt_fcheck = false;
+    cli.opt_fsyntax_only = true;
+  }
+
   if (!cli.opt_lsp && inputFiles.empty()) {
     std::cerr << "cxx: no input files" << std::endl
               << "Usage: cxx [options] file..." << std::endl;

src/frontend/cxx/frontend.cc

@@ -524,8 +524,7 @@ void Frontend::Private::parse() {
   }
 
   unit_->parse(ParserConfiguration{
-      .checkTypes =
-          cli.opt_fcheck || needsIR() || unit_->language() == LanguageKind::kC,
+      .checkTypes = cli.opt_fcheck,
       .fuzzyTemplateResolution = true,
       .allowUnprototypedFunctions = cli.opt_fno_strict_prototypes,
       .stopParsingPredicate = [this]() -> bool {

src/js/cxx/api.cc

@@ -32,14 +32,14 @@
 #include <emscripten/val.h>
 
 #include <cstdlib>
-#include <format>
-#include <iostream>
 #include <optional>
 #include <sstream>
 
 #ifdef CXX_WITH_MLIR
 #include <cxx/mlir/codegen.h>
 #include <cxx/mlir/cxx_dialect.h>
+#include <cxx/mlir/cxx_dialect_conversions.h>
+#include <cxx/wasm32_wasi_toolchain.h>
 #include <llvm/Support/raw_os_ostream.h>
 #include <mlir/IR/MLIRContext.h>
 #endif
@@ -72,6 +72,9 @@ struct WrappedUnit {
   std::unique_ptr<DiagnosticsClient> diagnosticsClient;
   std::unique_ptr<cxx::TranslationUnit> unit;
   val api;
+#ifdef CXX_WITH_MLIR
+  std::unique_ptr<cxx::Toolchain> toolchain_;
+#endif
 
   WrappedUnit(std::string source, std::string filename, val api = {})
       : api(api) {
@@ -84,6 +87,13 @@ struct WrappedUnit {
     }
 
     unit->beginPreprocessing(std::move(source), std::move(filename));
+
+#ifdef CXX_WITH_MLIR
+    auto tc = std::make_unique<cxx::Wasm32WasiToolchain>(unit->preprocessor());
+    tc->initMemoryLayout();
+    tc->addPredefinedMacros();
+    toolchain_ = std::move(tc);
+#endif
   }
 
   auto getUnitHandle() const -> std::intptr_t {
@@ -182,20 +192,25 @@ struct WrappedUnit {
 
     unit->endPreprocessing();
 
-    unit->parse();
+    unit->parse(cxx::ParserConfiguration{
+        .checkTypes = true,
+    });
 
     co_return val{true};
   }
 
   auto emitIR() -> std::string {
 #ifdef CXX_WITH_MLIR
     mlir::MLIRContext context;
+    context.disableMultithreading();
     context.loadDialect<mlir::cxx::CxxDialect>();
 
     cxx::Codegen codegen(context, unit.get());
 
     auto ir = codegen(unit->ast());
 
+    (void)cxx::lowerToMLIR(ir.module);
+
     mlir::OpPrintingFlags flags;
     flags.enableDebugInfo(true, true);
 
@@ -204,9 +219,7 @@ struct WrappedUnit {
     ir.module->print(os, flags);
     os.flush();
 
-    auto code = out.str();
-
-    return code;
+    return out.str();
 #else
     return {};
 #endif

src/mlir/cxx/mlir/codegen.cc

@@ -1204,7 +1204,7 @@ auto Codegen::getFileAttr(const std::string& filename)
     return it->second;
   }
 
-  auto filePath = absolute(std::filesystem::path{filename});
+  auto filePath = std::filesystem::path{filename};
 
   auto attr = mlir::LLVM::DIFileAttr::get(
       context_, filePath.filename().string(), filePath.parent_path().string());

src/parser/cxx/cli.cc

@@ -155,7 +155,10 @@ std::vector<CLIOptionDescr> options{
     {"-x", "Specify the language from the compiler driver, e.g. c, or c++",
      CLIOptionDescrKind::kSeparated},
 
-    {"-fcheck", "Enable type checker (WIP)", &CLI::opt_fcheck},
+    {"-fcheck", "Enable type checker", &CLI::opt_fcheck},
+
+    {"-fno-check", "Disable type checker (implies -fsyntax-only)",
+     &CLI::opt_fno_check},
 
     {"-fsyntax-only", "Check only the syntax", &CLI::opt_fsyntax_only},
 

src/parser/cxx/cli.h

@@ -70,7 +70,8 @@ class CLI {
   bool opt_S = false;
   bool opt_c = false;
   bool opt_fsyntax_only = false;
-  bool opt_fcheck = false;
+  bool opt_fcheck = true;
+  bool opt_fno_check = false;
   bool opt_freport_missing_types = false;
   bool opt_fno_reflect = false;
   bool opt_fno_strict_prototypes = false;

src/parser/cxx/substitution.cc

@@ -349,7 +349,7 @@ void Substitution::doMake() {
     if (!isPackParameter(parameters[i])) continue;
     packIndex = i;
 
-    // Count trailing non-pack parameters that don't have defaults —
+    // Count trailing non-pack parameters that don't have defaults -
     // they need their own arguments, so the pack can't consume those.
     int trailingRequired = 0;
     for (int j = i + 1; j < paramCount; ++j) {

src/parser/cxx/type_checker.cc

@@ -2256,7 +2256,7 @@ auto TypeChecker::Visitor::check_reinterpret_cast(ExpressionAST*& expression,
        check.unit_->typeTraits().is_enum(sourceType) ||
        check.unit_->typeTraits().is_scoped_enum(sourceType)) &&
       check.unit_->typeTraits().is_pointer(targetType)) {
-    // No implicit cast wrapper — CastExpressionAST codegen emits IntToPtrOp.
+    // No implicit cast wrapper - CastExpressionAST codegen emits IntToPtrOp.
     return true;
   }