Address final CWRU fixes for Issue #8 (#11)

* Address final CWRU fixes for Issue #8

* Update threshold sweep logic and add formal validation report

* Fix ruff formatting issues with imports and unused variables

Author: TasfinMahmud

cross_domain_validation.py cross_condition_robustness.pycross_domain_validation.py renamed to cross_condition_robustness.py

@@ -1,4 +1,5 @@
 import numpy as np
+import tensorflow as tf
 
 from cnsd import Dataset
 from cnsd.diagnosis.system import CNSD
@@ -25,8 +26,11 @@ def add_awgn(signals, snr_db):
 
 
 def main():
+    np.random.seed(42)
+    tf.random.set_seed(42)
+
     print('=' * 80)
-    print('CNSD CROSS-DOMAIN VALIDATION (AWGN NOISE INJECTION)')
+    print('CNSD CROSS-CONDITION ROBUSTNESS (AWGN NOISE INJECTION)')
     print('=' * 80)
 
     # 1. Load baseline data
@@ -52,7 +56,7 @@ def main():
     model.fit(train_data, epochs=30)
     print('Training complete.\n')
 
-    # 3. Evaluate on noisy cross-domains
+    # 3. Evaluate on noisy cross-conditions
     snr_levels = [None, 0, -5, -10]
 
     for snr in snr_levels:

validate_run.py

@@ -18,6 +18,7 @@
 """
 
 import numpy as np
+import tensorflow as tf
 
 from cnsd import Dataset
 from cnsd.causal import signal_kurtosis
@@ -79,11 +80,11 @@ def read_mat(path, label, load):
             dir_path = os.path.join(fault_dir, ftype, size)
             if not os.path.exists(dir_path):
                 continue
-            for f in os.listdir(dir_path):
-                if f.endswith('.mat'):
-                    load = int(f.split('_')[-1].split('.')[0])
-                    read_mat(os.path.join(dir_path, f), label, load)
-
+            for root, _dirs, files in os.walk(dir_path):
+                for f in files:
+                    if f.endswith('.mat'):
+                        load = int(f.split('_')[-1].split('.')[0])
+                        read_mat(os.path.join(root, f), label, load)
     return np.array(X, dtype=np.float32), np.array(y), np.array(cond)
 
 
@@ -126,6 +127,9 @@ def headline_accuracy_by_verdict(report, y_true):
 
 
 def main():
+    np.random.seed(42)
+    tf.random.set_seed(42)
+
     print('=' * 68)
     print('CNSD VALIDATION RUN (CWRU, Protocol B)')
     print('=' * 68)
@@ -222,9 +226,21 @@ def main():
         )
 
     # 7. example auditable diagnoses
-    print('\n[examples] auditable root-cause diagnoses:')
-    for r in report.records[:5]:
-        print(f'    [{r["status"]}] {r["root_cause"]["statement"]}')
+    print('\n[examples] auditable root-cause diagnoses (CONFIRMED faults only):')
+    seen_classes = set()
+    examples = []
+    for idx, r in enumerate(report.records):
+        y_true = test_data.y[idx]
+        if r['physics_verdict'] == 'CONFIRMED' and y_true > 0:
+            if y_true not in seen_classes:
+                examples.append(
+                    f'    [Class {y_true}] [{r["status"]}] {r["root_cause"]["statement"]}'
+                )
+                seen_classes.add(y_true)
+            if len(examples) >= 5:
+                break
+    for ex in examples:
+        print(ex)
 
     print('\n' + '=' * 68)
     print('VALIDATION COMPLETE - if all sections printed, the pipeline runs end-to-end.')

validation_report.md

@@ -0,0 +1,28 @@
+# CNSD Pipeline Validation Report (Issue #8)
+
+This document serves as a professional record of the experiments, fixes, and validation runs performed to harden the CWRU baseline for the CNSD causal-neurosymbolic system.
+
+## 1. Loader Bug Fix (Nested Subdirectories)
+The `load_cwru()` function was missing the `@3`, `@6`, and `@12` outer-race classes due to a rigid directory parsing logic. This was fixed by utilizing `os.walk` to comprehensively scan all nested subdirectories for `.mat` files. 
+
+**Result**: All 10 CWRU taxonomy classes are now correctly ingested.
+```text
+[train_data] Dataset 'CWRU_Train': 5806 samples, window=1024, fs=12000Hz, classes=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9], conditions=[0, 1, 2], physics=yes
+[test_data] Dataset 'CWRU_Test': 2019 samples, window=1024, fs=12000Hz, classes=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9], conditions=[3], physics=yes
+```
+
+## 2. Root-Cause Printing Fix
+The root-cause print loop was previously dumping raw physics vectors and showing "No defect detected". The logic was updated to specifically filter for `CONFIRMED` faults and uniquely print the human-readable physical descriptions of each fault class exactly once.
+
+**Result**: Clean, auditable, and human-readable root-cause statements.
+```text
+[examples] auditable root-cause diagnoses (CONFIRMED faults only):
+    [Class 2] [HIGH_CONFIDENCE] Defect on the rolling element (Ball), evidenced by a peak at the BSF (135.9 Hz, strength 3.5). a defect on a rolling element striking both races as it spins.
+    [Class 4] [HIGH_CONFIDENCE] Defect on the inner race (Inner Race), evidenced by a peak at the BPFI (156.1 Hz, strength 4.4). a defect on the rotating inner race, modulated by shaft rotation.
+    [Class 5] [HIGH_CONFIDENCE] Defect on the inner race (Inner Race), evidenced by a peak at the BPFI (156.1 Hz, strength 3.0). a defect on the rotating inner race, modulated by shaft rotation.
+    [Class 6] [HIGH_CONFIDENCE] Defect on the inner race (Inner Race), evidenced by a peak at the BPFI (156.1 Hz, strength 3.3). a defect on the rotating inner race, modulated by shaft rotation.
+    [Class 7] [HIGH_CONFIDENCE] Defect on the outer race (Outer Race), evidenced by a peak at the BPFO (103.4 Hz, strength 4.6). a defect on the stationary outer race struck by each rolling element.
+```
+
+## 3. Terminology Clarification
+The script `cross_domain_validation.py` was renamed to `cross_condition_robustness.py` to correctly reflect the protocol (AWGN noise injection). "Cross-domain" is reserved for multi-rig experiments (e.g., SEU/Paderborn).