chore: fix tests

Author: goldserg

lib/parser.js

@@ -75,14 +75,17 @@ const config = {
  *
  * @param {string} data
  * @param {string=} from
- * @param {number=} maxEntityCount Maximum number of XML entities the parser may
- *   expand, forwarded to sax as its XXE protection limit. When omitted, sax
- *   falls back to its own default (512 in sax >= 1.6.0).
+ * @param {number=} maxEntityCount Maximum number of XML entities the parser is
+ *   allowed to expand before throwing. When omitted, the underlying parser
+ *   falls back to its own default (512 in recent versions).
  * @returns {import('./types.js').XastRoot}
  */
 export const parseSvg = (data, from, maxEntityCount) => {
+  // Build a fresh options object per call: sax mutates the options it receives
+  // (e.g. it stamps a default `maxEntityCount`), so the shared `config` must
+  // not be passed directly.
   const parserConfig =
-    maxEntityCount == null ? config : { ...config, maxEntityCount };
+    maxEntityCount == null ? { ...config } : { ...config, maxEntityCount };
   const sax = SAX.parser(parserConfig.strict, parserConfig);
   /** @type {import('./types.js').XastRoot} */
   const root = { type: 'root', children: [] };

lib/parser.test.js

@@ -1,4 +1,5 @@
 import { jest } from '@jest/globals';
+import SAX from 'sax';
 import { parseSvg } from './parser.js';
 import { stringifySvg } from './stringifier.js';
 
@@ -33,53 +34,39 @@ test('a text preserved', () => {
 });
 
 describe('maxEntityCount', () => {
-  /**
-   * Re-import parseSvg with a mocked sax that records the options it receives.
-   *
-   * @returns {Promise<{ parseSvg: typeof parseSvg, getOpt: () => any }>}
-   */
-  const importWithSaxSpy = async () => {
-    /** @type {any} */
-    let receivedOpt;
-    jest.resetModules();
-    jest.unstable_mockModule('sax', () => ({
-      default: {
-        /**
-         * @param {boolean} _strict
-         * @param {any} opt
-         */
-        parser: (_strict, opt) => {
-          receivedOpt = opt;
-          return {
-            ENTITIES: {},
-            write() {
-              return this;
-            },
-            close() {
-              return this;
-            },
-          };
+  // sax mutates the options object it receives (it stamps a default
+  // `maxEntityCount`), so snapshot the options at call time, before sax runs.
+  /** @type {any} */
+  let receivedOpt;
+
+  beforeEach(() => {
+    jest.spyOn(SAX, 'parser').mockImplementation((_strict, opt) => {
+      receivedOpt = { ...opt };
+      // Minimal stub: parseSvg only assigns handlers then calls write().close().
+      return /** @type {any} */ ({
+        ENTITIES: {},
+        write() {
+          return this;
+        },
+        close() {
+          return this;
         },
-      },
-    }));
-    const mod = await import('./parser.js');
-    return { parseSvg: mod.parseSvg, getOpt: () => receivedOpt };
-  };
+      });
+    });
+  });
 
   afterEach(() => {
-    jest.dontMock('sax');
-    jest.resetModules();
+    jest.restoreAllMocks();
+    receivedOpt = undefined;
   });
 
-  test('forwards a provided maxEntityCount to the sax parser', async () => {
-    const { parseSvg: parse, getOpt } = await importWithSaxSpy();
-    parse('<svg xmlns="http://www.w3.org/2000/svg"/>', undefined, 1234);
-    expect(getOpt().maxEntityCount).toBe(1234);
+  test('forwards a provided maxEntityCount to the parser options', () => {
+    parseSvg('<svg xmlns="http://www.w3.org/2000/svg"/>', undefined, 1234);
+    expect(receivedOpt.maxEntityCount).toBe(1234);
   });
 
-  test('does not pass maxEntityCount when it is omitted', async () => {
-    const { parseSvg: parse, getOpt } = await importWithSaxSpy();
-    parse('<svg xmlns="http://www.w3.org/2000/svg"/>');
-    expect(getOpt().maxEntityCount).toBeUndefined();
+  test('does not set maxEntityCount when it is omitted', () => {
+    parseSvg('<svg xmlns="http://www.w3.org/2000/svg"/>');
+    expect(receivedOpt.maxEntityCount).toBeUndefined();
   });
 });

lib/svgo/coa.js

@@ -49,7 +49,7 @@ export default function makeProgram(program) {
     )
     .option(
       '--max-entity-count <INTEGER>',
-      'Maximum number of XML entities the parser may expand (sax XXE protection limit)',
+      'Maximum number of XML entities the parser may expand before throwing',
     )
     .option(
       '--config <CONFIG>',

lib/types.ts

@@ -345,8 +345,8 @@ export type Config = {
   floatPrecision?: number;
   /**
    * Maximum number of XML entities the parser is allowed to expand before
-   * throwing, forwarded to sax as its XXE protection limit. Defaults to sax's
-   * own default (512 in sax >= 1.6.0) when omitted.
+   * throwing. When omitted, the underlying parser falls back to its own
+   * default (512 in recent versions).
    */
   maxEntityCount?: number;
   /**