Skip to content

(bug) semver parsing in targeting queries is incomplete #3617

Description

@hairyhenderson

Observed behaviour

I have a targeting query like version gt 1.0.0-1234 where the provided version is 1.0.0-2345, and it's not matching.

However, according to semver precedence rules this should match. I tracked this down to a bug in the nikunjy/rules package - turns out versions were being parsed only as x.y.z with prerelease identifiers totally ignored. I have a fix up here: nikunjy/rules#43

Expected Behavior

Targeting queries like version gt 1.0.0-1234 where the provided version is 1.0.0-2345, should match!

Steps to reproduce

No response

Metadata

Metadata

Labels

bugSomething isn't workingneeds-triageA priority should be added to the issue

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions