Skip to content

sos-notebook tests fail because ipykernel.tests are no longer available #354

Description

@gaow

Rephrased from bug identified by @danielnachun: In our test,

import unittest

from sos_notebook.test_utils import sos_kernel
from ipykernel.tests.utils import execute, wait_for_idle, assemble_output

the last line does not work anymore, because even though this exists on GitHub, https://github.com/ipython/ipykernel/blob/main/tests/utils.py the pypi release does not contain it anymore: in the pyproject.toml for ipykernel on PyPI:

omit = [
  "tests/*",
  "ipykernel/datapub.py",
  "ipykernel/debugger.py",
  "ipykernel/eventloops.py",
  "ipykernel/log.py",
  "ipykernel/pickleutil.py",
  "ipykernel/serialize.py",
  "ipykernel/gui/*",
  "ipykernel/pylab/*",
]

So that means the tests folder is skipped by pip install. This results in failed tests of sos-notebook and thus rejection of any further updates to conda-forge. Not sure what our options are (other than removing tests) since it seems to be out of our hands that they decided to not include them. Or we copy and ship the test util with sos-notebook?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions