Feat: No implicit language fallback

[mcmah309]

language_factory should not fallback silently to English. It should return an option and fallback should be explicit.

sentencex/src/lib.rs

Line 27 in b55ee56

pub fn language_factory(language_code: &str) -> Box<dyn Language> {

[santhoshtr]

I left some comments in the PR. Given that this fix required to touch almost all files in the repo itself rings some alarms. Let us step back a bit and try to understand the real usecase we are trying to seve? Could you please elaborate it ? May be we can address it in different way.

[mcmah309]

If I pass in bingbongdingdong it will return a language implying - “Yup! Here’s that language for you”. When in actuality it uses English.

Given that this fix required to touch almost all files in the repo itself rings some alarms

Or it could have been designed better from the start without hidden behavior.

I left some comments in the PR

I don’t see any comments on the PR. You may not submitted your review