Adding ability to specify a date and time format#75
Open
atownsend247 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the user an option to override the default date format using the global glass_config.js file.
This was requested in the Issue #67 . I have added the moment library as this aids in parsing and formatting dates with ease.
I have replaced all instances of the human_time function with that using moment instead. The available options for the date/time can be derived from the following options found on the moment documentation: https://momentjs.com/docs/#/displaying/format/
Happy to further discuss changes/amendments if required.
I created this as I wanted to tweak the date/time formats myself as requested in Issue #67, so thought I'd go ahead and fix it now I've had some free time.