Skip to content

Included caffeinate command for trunk.sh#940

Open
ashp0 wants to merge 2 commits into
Alex313031:mainfrom
ashp0:patch-1
Open

Included caffeinate command for trunk.sh#940
ashp0 wants to merge 2 commits into
Alex313031:mainfrom
ashp0:patch-1

Conversation

@ashp0

@ashp0 ashp0 commented Feb 9, 2025

Copy link
Copy Markdown

My macbook fell asleep.... I had to do this all over again 😢

@Alex313031

Copy link
Copy Markdown
Owner

@ashp0 Can you change that one line to instead say
For this, run, from withing the Thorium repo (may take up to an hour):

@ashp0

ashp0 commented Feb 12, 2025

Copy link
Copy Markdown
Author

@Alex313031 Done!

@ashp0

ashp0 commented Feb 12, 2025

Copy link
Copy Markdown
Author

@Alex313031 Could you also release a new 2025 Thorium for macOS release? I couldn't build Thorium last week and apparently Chromium browsers are more power efficient on macOS than Safari.

Wow you released it!

Comment thread docs/BUILDING_MAC.md

First, we need to make sure we have all the tags/branches and are on Tip of Tree.
For this, run (from within the Thorium repo):
For this, run, from withing the Thorium repo (may take up to an hour):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why withing instead of within?

@Alex313031

Copy link
Copy Markdown
Owner

@DoNotResuscitate @ashp0 I'll merge this if you fix the typo withing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants