Skip to content

Improve gui build script for local development#20971

Draft
aqk wants to merge 1 commit into
mainfrom
improve-gui-build-script
Draft

Improve gui build script for local development#20971
aqk wants to merge 1 commit into
mainfrom
improve-gui-build-script

Conversation

@aqk

@aqk aqk commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Purpose:

no.

Current Behavior:

New Behavior:

Testing Notes:


Note

Low Risk
Single-line guard in the local install path only; no CI, auth, or runtime logic changes.

Overview
For local (non-CI) GUI installs, install-gui.sh now resets the repo root package-lock.json with git checkout immediately before git submodule update, with a short log line explaining why.

This avoids carrying accidental lockfile edits from local npm work into the submodule update and subsequent npm ci in chia-blockchain-gui, aligning with the same “restore lockfile before build” idea used elsewhere (e.g. clean-runner). CI behavior is unchanged ($CI still skips this block).

Reviewed by Cursor Bugbot for commit b87d148. Bugbot is set up for automated code reviews on this repo. Configure here.

@aqk aqk requested a review from a team as a code owner June 3, 2026 13:31

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b87d148. Configure here.

Comment thread install-gui.sh
# Ubuntu special cases above.
if [ ! "$CI" ]; then
echo "Undoing any package-lock.json changes before submodule update"
git checkout package-lock.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout wrong repo lockfile path

High Severity

Before submodule update, install-gui.sh runs git checkout package-lock.json in the parent chia-blockchain tree. That repo does not track a root package-lock.json (the GUI lockfile is in chia-blockchain-gui), so checkout typically fails and set -o errexit stops the local GUI install.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b87d148. Configure here.

@coveralls-official

Copy link
Copy Markdown

Coverage Report for CI Build 26888106101

Coverage decreased (-0.007%) to 91.487%

Details

  • Coverage decreased (-0.007%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 15 coverage regressions across 5 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

15 previously-covered lines in 5 files lost coverage.

File Lines Losing Coverage Coverage
chia/server/node_discovery.py 9 80.34%
chia/full_node/full_node.py 2 88.28%
chia/timelord/timelord_launcher.py 2 70.21%
chia/full_node/full_node_api.py 1 88.43%
chia/wallet/wallet_node.py 1 87.43%

Coverage Stats

Coverage Status
Relevant Lines: 122326
Covered Lines: 112090
Line Coverage: 91.63%
Relevant Branches: 12063
Covered Branches: 10859
Branch Coverage: 90.02%
Branches in Coverage %: Yes
Coverage Strength: 1.83 hits per line

💛 - Coveralls

@aqk aqk marked this pull request as draft June 3, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant