feat(application): add deployed_commit computed attribute#327
Draft
TheCrabe wants to merge 1 commit into
Draft
Conversation
Collaborator
|
We can to merge deployed_commit and deployment.commit. This 2 attributes are the same thing. |
Add a new computed attribute `deployed_commit` that shows the commit hash of the most recent successful deployment. This allows users to see what is actually deployed without causing drift on the `deployment.commit` input.
TheCrabe
force-pushed
the
fix/update-deploy-commit-on-read
branch
from
0fcb4c3 to
ee32b77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployed_committo all application resourcesdeployment.commitMotivation
Closes #100
Users wanted to know what commit is actually deployed on their application. Previously,
deployment.commitonly showed what was requested to deploy (e.g.,refs/heads/main), not the actual deployed commit hash.