[CASCL-1386] (11/11) Create temporary PodDisruptionBudgets during eviction#3178
Draft
L3n41c wants to merge 1 commit into
Draft
[CASCL-1386] (11/11) Create temporary PodDisruptionBudgets during eviction#3178L3n41c wants to merge 1 commit into
L3n41c wants to merge 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lenaic/CASCL-1386-evict-10-karpenter-user #3178 +/- ##
=============================================================================
+ Coverage 44.41% 44.57% +0.15%
=============================================================================
Files 391 391
Lines 31316 31483 +167
=============================================================================
+ Hits 13910 14033 +123
- Misses 16508 16544 +36
- Partials 898 906 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
6a978ac to
1a070c5
Compare
e6ebd52 to
c0b814f
Compare
1a070c5 to
3cdcaf0
Compare
08904e2 to
43a0d78
Compare
3cdcaf0 to
2b49dd2
Compare
5 tasks
2b49dd2 to
d88c10a
Compare
43a0d78 to
1505efe
Compare
d88c10a to
6b94424
Compare
045f39b to
f21be8d
Compare
6b94424 to
d391f26
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
f21be8d to
4fbbbac
Compare
d391f26 to
8b7a293
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements creation and label-based cleanup of temporary PodDisruptionBudgets (
maxUnavailable: 1) that protect cross-group workloads during the drain.Motivation
PR #3026 is too large to review as a single change. This is part 11 of 11 of a stack that splits it into small, individually-reviewable pieces that each build and pass tests on their own. See #3026 for the full feature context and end-to-end QA.
Additional Notes
Stacked PR — the base branch is
lenaic/CASCL-1386-evict-10-karpenter-user, notmain, so the diff shows only this step's change. Lands last because its controller discovery (discoverControllers) reuses theshouldSkipEvictionpredicate introduced in part 8. The code is taken verbatim from #3026 (rebased ontomain); there are no logic changes versus #3026.Minimum Agent Versions
N/A —
kubectl-datadogplugin only.Describe your test plan
go test ./cmd/kubectl-datadog/autoscaling/cluster/...passes at this commit. Full end-to-end QA is tracked on #3026.Checklist
qa/skip-qalabel applied (not independently shippable; QA tracked on [CASCL-1386] Add evict-legacy-nodes subcommand to drain non-Datadog node groups #3026)