rework the EPK editor and reorganise the charter toolkit#752
Merged
Conversation
Rebuild the manifest metadata editor from a cramped single-column form into a dense, responsive two-column card layout that matches the app's other pages. Regroup and rename the fields to the product's canonical vocabulary (Basic Info / Chart Info / Description & Discovery / Maps; Song Author, Rating as "定数", Maps as "地图", ...), make Description a real multi-line field, align the per-map rows, and give it a file-editor feel: an unsaved-changes dot, Ctrl+S, and staying open on save instead of bouncing back to the launcher. Drive the map list from the folder. The editable difficulties are now the union of the manifest's maps and the .bms files actually present, so a difficulty dropped into the folder shows up (after Refresh) as an editable row and a removed one drops out; saving writes every present map back. Required-field validation now covers name, author, scene, BPM, the presence of a Hard (map2), and a rating + charter for every map present. Add a New-EPK entry that builds a blank manifest from a folder of assets, and reorganise the toolkit into Offline tools (New / Open EPK) and Online tools (Chart Analyzer and Submit Chart, which open the Euterpe site), each as a card-style launcher tile. Localisation is updated across all 14 locales. No backend or serialization changes: the manifest model and all file I/O are untouched.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Reworks the EPK metadata editor UI/UX and reorganizes the charter toolkit landing, adding folder-driven map reconciliation, stricter save validation, and new toolkit entry points (offline/online), with corresponding localization updates.
Changes:
- Updated
EpkEditorPanellayout (two-column card UI), added Ctrl+S save, unsaved-changes indicator, and refreshed file/map presentation. - Enhanced
EpkEditorPanelViewModelwith stricterCanSavevalidation and a reconcile step to reflect folder file changes in map rows. - Reorganized
CharterToolkitPanelinto Offline/Online tools and added “New EPK…” flow; updated strings across locales.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Euterpe.Tests/App/ViewModels/EpkEditorPanelViewModelTest.cs | Adds tests for folder-driven map reconciliation and new save-validation rules. |
| src/Euterpe/Features/Charting/EpkEditorPanelViewModel.cs | Implements new dirty tracking, expanded CanSave validation, and map/file reconciliation on refresh. |
| src/Euterpe/Features/Charting/EpkEditorPanel.axaml | Rebuilds the editor UI into card-based two-column layout; adds Ctrl+S and dirty indicator. |
| src/Euterpe/Features/Charting/CharterToolkitPanelViewModel.cs | Adds “New EPK” command and injects file-system access for folder-based manifest creation. |
| src/Euterpe/Features/Charting/CharterToolkitPanel.axaml | Reorganizes toolkit landing into Offline/Online tool cards with URL launchers. |
| src/Euterpe.Localization/XAML/XAML*.resx | Adds new toolkit/editor strings and updates terminology across all locales. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
323
to
327
| var manifestMap = manifestMaps?.GetValueOrDefault(ChartFiles.MapName(difficulty)); | ||
| if (manifestMap is null && !_files.ContainsKey(ChartFiles.MapFileName(difficulty))) | ||
| { | ||
| continue; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the EPK metadata editor and the charter toolkit landing. No backend or serialization changes — the manifest model and all file I/O are untouched.
Editor
Maps
Toolkit
Localisation
Testing