fix(session): list_namespaces mirrors list_tables resolution#7144
fix(session): list_namespaces mirrors list_tables resolution#7144YuangGao wants to merge 1 commit into
Conversation
Greptile SummaryThis PR fixes
Confidence Score: 5/5Safe to merge — the change is a well-scoped addition with no modifications to existing write paths or table resolution logic. The new No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Session.list_namespaces(pattern)"] --> B{pattern has a dot\nAND head is\nattached catalog?}
B -- Yes --> C["get_catalog(head)\n.list_namespaces(rest)"]
C --> D["qualify results\nwith catalog alias"]
D --> E["return [cat.ns, ...]"]
B -- No --> F{current catalog\nset?}
F -- No --> G["return []"]
F -- Yes --> H["get_catalog(alias)\n.list_namespaces(pattern)"]
H --> I["qualify results\nwith alias"]
I --> E
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["Session.list_namespaces(pattern)"] --> B{pattern has a dot\nAND head is\nattached catalog?}
B -- Yes --> C["get_catalog(head)\n.list_namespaces(rest)"]
C --> D["qualify results\nwith catalog alias"]
D --> E["return [cat.ns, ...]"]
B -- No --> F{current catalog\nset?}
F -- No --> G["return []"]
F -- Yes --> H["get_catalog(alias)\n.list_namespaces(pattern)"]
H --> I["qualify results\nwith alias"]
I --> E
Reviews (1): Last reviewed commit: "list_namespaces mirrors list_tables reso..." | Re-trigger Greptile |
Changes Made
Session.list_namespacesignored attached catalogs and raised when no current catalog was set. It now mirrorsSession::list_tables(#7126):<catalog>.<rest>patterns dispatch exclusively to that attached catalogset_namespace/list_tables/read_table[]instead of raisingValueErrorAdds
Session::list_namespacesin Rust +PySessionshim and switches the Python wrapper to delegate.Related Issues
Closes #7134