Skip to content

fix(honeytoken): serialize concurrent plant runs with an advisory lock#1278

Merged
jCOTINEAU merged 1 commit into
mainfrom
jeremycotineau/hon-1407-plant-honeytoken-atomic-write-advisory-lock-on
Jun 25, 2026
Merged

fix(honeytoken): serialize concurrent plant runs with an advisory lock#1278
jCOTINEAU merged 1 commit into
mainfrom
jeremycotineau/hon-1407-plant-honeytoken-atomic-write-advisory-lock-on

Conversation

@jCOTINEAU

@jCOTINEAU jCOTINEAU commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Hold an exclusive flock on the .aws dir fd for the whole read-modify-write window (write and remove) so two concurrent plant runs can't lose each other's update. Released on fd close or process death — no stale lock. POSIX only.

Refs HON-1407

Context

What has been done

Validation

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

@jCOTINEAU jCOTINEAU requested a review from a team as a code owner June 15, 2026 08:25
@linear

linear Bot commented Jun 15, 2026

Copy link
Copy Markdown

HON-1407

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.45%. Comparing base (43eaf2b) to head (2611b35).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1278   +/-   ##
=======================================
  Coverage   93.44%   93.45%           
=======================================
  Files         189      189           
  Lines       11003    11014   +11     
=======================================
+ Hits        10282    10293   +11     
  Misses        721      721           
Flag Coverage Δ
unittests 93.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Hold an exclusive flock on the .aws dir fd for the whole read-modify-write window (write and remove) so two concurrent plant runs can't lose each other's update. Released on fd close or process death — no stale lock. POSIX only.

Refs HON-1407
@jCOTINEAU jCOTINEAU force-pushed the jeremycotineau/hon-1407-plant-honeytoken-atomic-write-advisory-lock-on branch from 3a50903 to 2611b35 Compare June 15, 2026 09:09
@jCOTINEAU jCOTINEAU merged commit 4a75b7a into main Jun 25, 2026
37 checks passed
@jCOTINEAU jCOTINEAU deleted the jeremycotineau/hon-1407-plant-honeytoken-atomic-write-advisory-lock-on branch June 25, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants