Drop the .NET Framework 4.8 designer; keep only InfoBoxCore.Designer#91
Open
JohannBlais wants to merge 1 commit into
Open
Drop the .NET Framework 4.8 designer; keep only InfoBoxCore.Designer#91JohannBlais wants to merge 1 commit into
JohannBlais wants to merge 1 commit into
Conversation
The designer existed as two projects compiling the same source: the legacy non-SDK InfoBox.Designer.csproj (net48, WinExe) and the SDK-style InfoBoxCore.Designer.csproj (net8/9/10). Unlike the library, the designer is a dev tool that is NOT shipped in the NuGet package, so a net48 build has no external consumer - a modern build is sufficient. Rather than multi-target it (as we did for the library), the net48 designer project is simply removed: - Delete InfoBox.Designer.csproj. The InfoBox.Designer/ folder keeps the designer source, which InfoBoxCore.Designer already compiles via <Compile Include="..\InfoBox.Designer\**\*.cs" />. - Delete the net48-project-only orphans that nothing else references: app.config, Properties/app.manifest, Properties/key.snk, and the ClickOnce InfoBox.Designer_TemporaryKey.pfx. - InfoBox.sln: remove the InfoBox.Designer project entry + config. - CLAUDE.md: update the project-structure section. This also removes the MSB3884 "AllRules.ruleset not found" warning that the old-format designer emitted under `dotnet build`. Verified: `dotnet build InfoBox.sln` succeeds, designer tests 8/8, library tests 88/88. Stacked on #90 (the library consolidation) since both edit InfoBox.sln. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to #90, for the designer projects. Same two-project situation (a legacy net48 designer + a modern SDK designer compiling the same source), but resolved differently: since the designer is a dev tool not shipped in the NuGet package, a net48 build has no external consumer — so instead of multi-targeting it, the net48 designer is simply removed.
Changes
InfoBox.Designer.csproj. TheInfoBox.Designer/folder keeps the designer source, whichInfoBoxCore.Designeralready compiles via<Compile Include="..\InfoBox.Designer\**\*.cs" />.app.config,Properties/app.manifest,Properties/key.snk, and the ClickOnceInfoBox.Designer_TemporaryKey.pfx.InfoBox.sln: remove the InfoBox.Designer project entry + its config block.CLAUDE.md: update the project-structure section (InfoBox.Designer/ is now source-only; InfoBoxCore.Designer is the single designer project, net8/9/10).Also removes the
MSB3884"AllRules.ruleset not found" warning the old-format designer emitted underdotnet build.Verified locally
dotnet build InfoBox.slnInfoBoxCore.Designer.Tests)InfoBoxCore.Tests)Stacked on #90 (both edit
InfoBox.slnon adjacent lines). Base is set to thechore/consolidate-net48-into-infoboxcorebranch so the diff shows only the designer changes. Merge #90 first, then this. If GitHub doesn't cleanly retarget after #90's squash-merge, I'll rebase this ontomasterand update.🤖 Generated with Claude Code