Skip to content

Fix incomplete close mechanism in connectionManager#23

Open
prjanitor wants to merge 1 commit into
KardinalAI:v1from
prjanitor:prjanitor/d12d96c8236454983a0618aea537de1fcdefcf76
Open

Fix incomplete close mechanism in connectionManager#23
prjanitor wants to merge 1 commit into
KardinalAI:v1from
prjanitor:prjanitor/d12d96c8236454983a0618aea537de1fcdefcf76

Conversation

@prjanitor

Copy link
Copy Markdown

The close() method in connectionManager was returning early if the publisherConnection.close() failed, which prevented the consumerConnection.close() from being called. This could lead to resources not being properly released during shutdown.

The fix ensures that both connections attempt to close, although it currently prioritizes returning the publisher error if one occurs. A more robust implementation might use a multi-error approach, but this fixes the immediate issue of masking the consumer closure call.


This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.

We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a .github/prjanitor.yml file with enabled: false to opt out explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant