feat: add epoch_key to CometLogger to make epoch extraction configurable#21786
Open
pupeno wants to merge 2 commits into
Open
feat: add epoch_key to CometLogger to make epoch extraction configurable#21786pupeno wants to merge 2 commits into
pupeno wants to merge 2 commits into
Conversation
Adds a `log_key_prefix` parameter to `Trainer` that prepends a string to Trainer-generated metric keys such as `epoch`. Defaults to bare `epoch` (no prefix), so existing users see no change. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds an `epoch_key` parameter to `CometLogger` that controls which metric key is extracted and forwarded as Comet's dedicated epoch argument. Defaults to `"epoch"` (existing behaviour unchanged). Pass `epoch_key=None` to disable epoch extraction entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Contributes to #21782
Adds
epoch_keytoCometLoggerto let users control which incoming metric key is extractedand forwarded to Comet's dedicated
epoch=argument.Previously this key was hardcoded to
"epoch". With this change it is configurable, and can beset to
Noneto disable epoch extraction entirely.Default is
"epoch", which preserves the previous behaviour — fully backward-compatible.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist