feat: customizable lint severity levels#2301
Conversation
…and optimizing import usage computation
…DiagnosticSeverity::HINT`.
Summary of ChangesHello @hongjr03, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the linting capabilities by introducing configurable severity levels for lint rules and implementing a robust dead code detection system. These changes provide users with greater flexibility in managing their codebase's health and offer automated solutions for common issues, improving the overall development workflow and code quality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable linting framework, allowing users to set severity levels for different lint rules. It also adds a new dead-code analysis lint, complete with quick fixes to remove or suppress unused code. The implementation is extensive, touching on diagnostics, code actions, and configuration.
I've found a critical issue in the dead-code analysis logic that prevents it from detecting usages correctly, both within the same file and across files. This needs to be addressed for the feature to work as intended.
Overall, this is a great feature addition that will improve the development experience. Once the bug is fixed, this will be a solid contribution.
This depends on and should be merged after #2245.
Implement configurable lint severity levels allowing users to customize diagnostic severity per rule with enhanced LSP diagnostic metadata.