Skip to content

feat: customizable lint severity levels#2301

Draft
hongjr03 wants to merge 35 commits into
Myriad-Dreamin:mainfrom
hongjr03:feat/severity
Draft

feat: customizable lint severity levels#2301
hongjr03 wants to merge 35 commits into
Myriad-Dreamin:mainfrom
hongjr03:feat/severity

Conversation

@hongjr03

@hongjr03 hongjr03 commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

This depends on and should be merged after #2245.

Implement configurable lint severity levels allowing users to customize diagnostic severity per rule with enhanced LSP diagnostic metadata.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @hongjr03, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the linting capabilities by introducing configurable severity levels for lint rules and implementing a robust dead code detection system. These changes provide users with greater flexibility in managing their codebase's health and offer automated solutions for common issues, improving the overall development workflow and code quality.

Highlights

  • Configurable Lint Severity: Users can now customize the diagnostic severity level for individual linting rules, allowing for fine-grained control over how linting issues are presented.
  • Dead Code Detection: A new dead code linter has been integrated, capable of identifying unused bindings, functions, and imports within Typst files, including cross-file references.
  • Enhanced LSP Diagnostic Metadata: LSP diagnostics now include richer metadata, such as specific lint rules and dead code kinds, enabling clients to provide more context-aware features like quick-fixes.
  • Quick-Fixes for Dead Code: New code actions are available to automatically address dead code, including prefixing unused symbols with an underscore, replacing them with a placeholder, or removing unused declarations and import items.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configurable linting framework, allowing users to set severity levels for different lint rules. It also adds a new dead-code analysis lint, complete with quick fixes to remove or suppress unused code. The implementation is extensive, touching on diagnostics, code actions, and configuration.

I've found a critical issue in the dead-code analysis logic that prevents it from detecting usages correctly, both within the same file and across files. This needs to be addressed for the feature to work as intended.

Overall, this is a great feature addition that will improve the development experience. Once the bug is fixed, this will be a solid contribution.

Comment thread crates/tinymist-query/src/analysis/global.rs
Comment thread crates/tinymist-query/src/analysis/global.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant