fix(agent): detect modern services.ai.azure.com in _is_azure_openai_url()#47672
Closed
liuhao1024 wants to merge 1 commit into
Closed
fix(agent): detect modern services.ai.azure.com in _is_azure_openai_url()#47672liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
…rl()
Modern Azure OpenAI resources (post-2024) use
`{resource}.services.ai.azure.com` instead of the legacy
`{resource}.openai.azure.com`. The substring check missed these
endpoints, causing Azure-specific routing to fail for gpt-5.x models
served without the `/v1/` prefix.
Extend the detection to also match `ai.azure.com` and update the
docstring to document both URL patterns.
Collaborator
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends
_is_azure_openai_url()to detect modern Azure OpenAI endpoints (*.services.ai.azure.com) in addition to the legacy*.openai.azure.compattern. This ensures Azure-specific routing works correctly for post-2024 Azure OpenAI resources.Related Issue
Fixes #47666
Type of Change
Changes Made
run_agent.py: Extended_is_azure_openai_url()substring check to also matchai.azure.com, covering modern*.services.ai.azure.comendpoints. Updated docstring to document both URL patterns.tests/run_agent/test_run_agent.py: Added assertions for*.services.ai.azure.comURLs intest_is_azure_openai_url_detection.How to Test
pytest tests/run_agent/test_run_agent.py::TestGpt5ApiModeRouting -xvs— all 4 tests should passservices.ai.azure.comURLs returnTrue, legacyopenai.azure.comstill works, and non-Azure URLs still returnFalseChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/ACode Intelligence
_is_azure_openai_url(callers: 3 —run_agent.py:1272,agent_init.py:385,chat_completion_helpers.py:1145)TestGpt5ApiModeRouting)