Migrate pack #6 of datasources and resources to terraform plugin framework#903
Draft
cjgajard wants to merge 8 commits into
Draft
Migrate pack #6 of datasources and resources to terraform plugin framework#903cjgajard wants to merge 8 commits into
cjgajard wants to merge 8 commits into
Conversation
Migrate data source automation actions action
10554ab to
edfb8c9
Compare
imjaroiswebdev
requested changes
Jul 12, 2024
imjaroiswebdev
left a comment
Contributor
There was a problem hiding this comment.
@cjgajard Great job! This pretty good to me, let's keep it open until PagerDuty/go-pagerduty gets updated.
| gopkg.in/ini.v1 v1.67.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/PagerDuty/go-pagerduty => github.com/cjgajard/go-pagerduty v0.0.0-20240712203852-d83eacdec105 |
Contributor
There was a problem hiding this comment.
Reminder: drop this replace and update deps after PagerDuty/go-pagerduty gets updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes migration to terraform plugin framework for:
pagerduty_automation_actions_actiondata.pagerduty_automation_actions_actionpagerduty_automation_actions_action_service_associationpagerduty_automation_actions_action_team_associationpagerduty_automation_actions_runnerpagerduty_automation_actions_runner_team_associationdata.pagerduty_automation_actions_runnerAcceptance tests results after migration of above TF Objects...