[codex] Fix tool calling probe for thinking models#270
Draft
Rabithua wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_choice: "auto"instead of forcing a specific function tool.tool_choice: "auto".Why
Some thinking/reasoning model providers reject
tool_choice: "required"or function-object tool choices while thinking mode is enabled. The probe was surfacing that provider 400 as a missing tool-calling result.Validation
cd web && bun run test src/utils/personalAiProvider.test.tscd server && bun test tests/aiClient.test.tscd web && bun run lintcd web && bun run buildcd server && bun run lintcd server && bun run build